From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3173FC433F5 for ; Sun, 30 Jan 2022 23:14:53 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5787E8369F; Mon, 31 Jan 2022 00:14:48 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="KdJFWpxi"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 35E6283678; Mon, 31 Jan 2022 00:14:46 +0100 (CET) Received: from mail-ua1-x935.google.com (mail-ua1-x935.google.com [IPv6:2607:f8b0:4864:20::935]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D845D835BA for ; Mon, 31 Jan 2022 00:14:42 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-ua1-x935.google.com with SMTP id u6so10963292uaq.0 for ; Sun, 30 Jan 2022 15:14:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uUSoYZduNfAI6feBVlEq0PXC8mVaFxzBtrX7kLMXdtA=; b=KdJFWpxiPMf5rDueWRaj/GZS/iuddOBmdo9IxKk/czMlrtHqwV6gvYxjLrUmz3H+Wy b81O9v14p/N9SMjGWCz3o38nx1s12EK402O3OlkAKjBkrjsspokHMPubRXLmOOMHWhmm AyeftJ8Rs7eeSQKwE2ElPN+Jej/IEhgbxTPl0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uUSoYZduNfAI6feBVlEq0PXC8mVaFxzBtrX7kLMXdtA=; b=qFuw78VzC4qgxydXEM1lfo/imox3x6toGGAolShJqhxDmmrWZ7dOlyBPpFw5HRn7bW 9HbF9dqPS4sEVZW/9qL1Ns0xIDT8cZgJYOXQVf2apa4SOusDquM2XLR0cxBewE3+uLhB m5tnE1/VGsg5OYosDCRq9X+RFQn8siirj1c7xweA+T0h9gmbC4Kv7Apd1WVgx4Txn3TK RVB26jF33lFiXuQ1PZ4vCoD2KhQAmMltFTubheuci3fPJ+mCU6/Y2hCZTHixW2fryoH0 ygRSoOY0XDJlqlsloRdpyOp+6OX+68MEdo7NfEgcsBdVoKjyfoWi3Fj7fS0tEItecylr RHQA== X-Gm-Message-State: AOAM532csgUqyS2S20ISadyNi7sbhcUZisTuQBYPyzzwkKm7AGIJzx+i /byVgZ/ja4aVwjc4j6vLd6YoyCnki5fblCL9aWrmMU+kQmM= X-Google-Smtp-Source: ABdhPJza9Z54Ww/Hjmt10U1rvuA5UEVzTynVRnIqxisp0oh6XSN48sn36+S28vp/LtEDDjOBZeBByujZbrfJvesS4is= X-Received: by 2002:ab0:b8b:: with SMTP id c11mr6989681uak.35.1643584481396; Sun, 30 Jan 2022 15:14:41 -0800 (PST) MIME-Version: 1.0 References: <20220128184211.160575-1-heinrich.schuchardt@canonical.com> <14ccdea6-47bd-ac2a-6741-bef7bac211cb@canonical.com> In-Reply-To: <14ccdea6-47bd-ac2a-6741-bef7bac211cb@canonical.com> From: Simon Glass Date: Sun, 30 Jan 2022 16:14:30 -0700 Message-ID: Subject: Re: [PATCH 1/1] lib: allow printing RISC-V EFI Boot Protocol GUID To: Heinrich Schuchardt Cc: Tom Rini , Patrick Delaunay , U-Boot Mailing List , Sunil V L Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Hi Heinrich, On Sat, 29 Jan 2022 at 14:40, Heinrich Schuchardt wrote: > > > > On 1/29/22 22:09, Simon Glass wrote: > > Hi Heinrich, > > > > On Fri, 28 Jan 2022 at 11:42, Heinrich Schuchardt > > wrote: > >> > >> On RISC-V a new UEFI protocol has been introduced. Support printing > >> its GUID using %pUs. > >> > >> Cc: Sunil V L > >> Signed-off-by: Heinrich Schuchardt > >> --- > >> cf. > >> [RFC PATCH V2 1/2] efi_loader: Enable RISCV_EFI_BOOT_PROTOCOL support > >> https://lists.denx.de/pipermail/u-boot/2022-January/473505.html > >> --- > >> lib/uuid.c | 6 ++++++ > >> 1 file changed, 6 insertions(+) > >> > >> diff --git a/lib/uuid.c b/lib/uuid.c > >> index 24571ef5fb..284f8113ff 100644 > >> --- a/lib/uuid.c > >> +++ b/lib/uuid.c > >> @@ -220,7 +220,13 @@ static const struct { > >> "TCG2 Final Events Table", > >> EFI_TCG2_FINAL_EVENTS_TABLE_GUID, > >> }, > >> +#ifdef CONFIG_EFI_RISCV_BOOT_PROTOCOL > >> + { > >> + "RISC-V Boot", > >> + RISCV_EFI_BOOT_PROTOCOL_GUID, > >> + }, > >> #endif > >> +#endif /* CONFIG_CMD_EFIDEBUG */ > >> #ifdef CONFIG_CMD_NVEDIT_EFI > >> /* signature database */ > >> { > >> -- > >> 2.33.1 > >> > > > > Why the #ifdef? > > We want a small size of the binary. Why should we add a text for a > RISC-V GUID on ARM? If we wanted a small binary size we would not be using UUIDs. I was thinking that if you load an image for another arch it would be very confusing if it were not recognised. Regards, Simon