All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] rockchip: tinker: configs: use correct mmc instance as boot target device
@ 2017-02-20  3:08 Eddie Cai
  2017-02-22  3:59 ` Simon Glass
  0 siblings, 1 reply; 3+ messages in thread
From: Eddie Cai @ 2017-02-20  3:08 UTC (permalink / raw)
  To: u-boot

We are using wrong mmc instance as boot target device now. below Jaehoon Chung's
patch use mmc alias which correct it. That make tinker board can not find mmc
device. So give it correct mmc device instance.

        commit 02ad33aa3a84821c8d9a6c4f167f143f6248b084
        Author: Jaehoon Chung <jh80.chung@samsung.com>
        Date:   Thu Feb 2 13:41:14 2017 +0900

            mmc: mmc-uclass: use the fixed devnum with alias node

Signed-off-by: Eddie Cai <eddie.cai.linux@gmail.com>
---
 include/configs/tinker_rk3288.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/configs/tinker_rk3288.h b/include/configs/tinker_rk3288.h
index 860eb40..c398e07 100644
--- a/include/configs/tinker_rk3288.h
+++ b/include/configs/tinker_rk3288.h
@@ -13,7 +13,7 @@
 #undef BOOT_TARGET_DEVICES
 
 #define BOOT_TARGET_DEVICES(func) \
-	func(MMC, mmc, 0)
+	func(MMC, mmc, 1)
 
 #define CONFIG_ENV_IS_IN_MMC
 #define CONFIG_SYS_MMC_ENV_DEV 0
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] rockchip: tinker: configs: use correct mmc instance as boot target device
  2017-02-20  3:08 [U-Boot] rockchip: tinker: configs: use correct mmc instance as boot target device Eddie Cai
@ 2017-02-22  3:59 ` Simon Glass
  2017-02-23 16:19   ` Simon Glass
  0 siblings, 1 reply; 3+ messages in thread
From: Simon Glass @ 2017-02-22  3:59 UTC (permalink / raw)
  To: u-boot

On 19 February 2017 at 20:08, Eddie Cai <eddie.cai.linux@gmail.com> wrote:
> We are using wrong mmc instance as boot target device now. below Jaehoon Chung's
> patch use mmc alias which correct it. That make tinker board can not find mmc
> device. So give it correct mmc device instance.
>
>         commit 02ad33aa3a84821c8d9a6c4f167f143f6248b084
>         Author: Jaehoon Chung <jh80.chung@samsung.com>
>         Date:   Thu Feb 2 13:41:14 2017 +0900
>
>             mmc: mmc-uclass: use the fixed devnum with alias node
>
> Signed-off-by: Eddie Cai <eddie.cai.linux@gmail.com>
> ---
>  include/configs/tinker_rk3288.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Simon Glass <sjg@chromium.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] rockchip: tinker: configs: use correct mmc instance as boot target device
  2017-02-22  3:59 ` Simon Glass
@ 2017-02-23 16:19   ` Simon Glass
  0 siblings, 0 replies; 3+ messages in thread
From: Simon Glass @ 2017-02-23 16:19 UTC (permalink / raw)
  To: u-boot

On 21 February 2017 at 20:59, Simon Glass <sjg@chromium.org> wrote:
> On 19 February 2017 at 20:08, Eddie Cai <eddie.cai.linux@gmail.com> wrote:
>> We are using wrong mmc instance as boot target device now. below Jaehoon Chung's
>> patch use mmc alias which correct it. That make tinker board can not find mmc
>> device. So give it correct mmc device instance.
>>
>>         commit 02ad33aa3a84821c8d9a6c4f167f143f6248b084
>>         Author: Jaehoon Chung <jh80.chung@samsung.com>
>>         Date:   Thu Feb 2 13:41:14 2017 +0900
>>
>>             mmc: mmc-uclass: use the fixed devnum with alias node
>>
>> Signed-off-by: Eddie Cai <eddie.cai.linux@gmail.com>
>> ---
>>  include/configs/tinker_rk3288.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Acked-by: Simon Glass <sjg@chromium.org>

Applied to u-boot-rockchip, thanks!

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-02-23 16:19 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-20  3:08 [U-Boot] rockchip: tinker: configs: use correct mmc instance as boot target device Eddie Cai
2017-02-22  3:59 ` Simon Glass
2017-02-23 16:19   ` Simon Glass

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.