From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4FE5AC433EF for ; Fri, 11 Feb 2022 21:02:20 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C8D1883BAA; Fri, 11 Feb 2022 22:02:17 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="jxQdYwsQ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B6A6083BAF; Fri, 11 Feb 2022 22:02:16 +0100 (CET) Received: from mail-vk1-xa2c.google.com (mail-vk1-xa2c.google.com [IPv6:2607:f8b0:4864:20::a2c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3FB5F83839 for ; Fri, 11 Feb 2022 22:02:13 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-vk1-xa2c.google.com with SMTP id o129so4870494vko.7 for ; Fri, 11 Feb 2022 13:02:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/QKimt7F71ASNM1YFowPkGKNBVElY7QQbY37lyhzNog=; b=jxQdYwsQSqogpVrG1qxLFfdaKl99lRoUJdFxi82ut5dNtpNFTjz9ltWgPst1d86YsH dEC0HW1GFPM01BF1k1Y9t55XVxlDAqFqJznemUDISwdcuYs6EkRk8xjKeuAaClgfXYAP wFxAwt8TsdJBepiKz9VEcGVn4ZMomlxC4adIA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/QKimt7F71ASNM1YFowPkGKNBVElY7QQbY37lyhzNog=; b=XIsdTlSa8fzCQqjnEWMruYdzZuk8ALaPZWc841qj2GDlS0xb/9+xCoPdqG0Luy/NCi 3+BwgIMz8sxYicJNtSlLRCfa+2bbyUIhf5x11hQKwS4E9RSe24C9arjtLIfmQJf+i2Kp GsZtW1l+dGBf8mLxopTBLQVxFWsjeR4E29DcXFGT30NQqxWb7BN++Di5K4Gz6jxmwazI 8ZyICKYKjARL0BWdYYKLsCx33XRtIjPp/Be2ljhFruCYL0TzPOyv4159qz2oaskk2pBK WDG4LBYa2r2BapD7kWEyNM9oS3GZtqzFLv7i5TEy9EhfKVev219JX2Fkdrj/WpVaDDPn qmJw== X-Gm-Message-State: AOAM533AXNa6M7WY3QgSr+1sor2wOLiwxwueTbJLp/4bLSAlnekE6EKT zTMn9MGeqlKf77ALOl+q4ye3pqeUdl7DpXdIRQCJMQ== X-Google-Smtp-Source: ABdhPJyajVcMZ3JYRfbKsH53IBosxSduPjKoZMjq/AwHrCRmNSaUXBkhgPH6q+uvhW3rW7ZMGlSbnwfNgcrWWj4ZTwc= X-Received: by 2002:a05:6122:990:: with SMTP id g16mr1135898vkd.3.1644613330418; Fri, 11 Feb 2022 13:02:10 -0800 (PST) MIME-Version: 1.0 References: <20220211200013.18947-1-kettenis@openbsd.org> In-Reply-To: From: Simon Glass Date: Fri, 11 Feb 2022 14:01:59 -0700 Message-ID: Subject: Re: [PATCH] arm: apple: Disable debug UART To: Mark Kettenis Cc: Mark Kettenis , U-Boot Mailing List , Tom Rini Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Hi Mark, On Fri, 11 Feb 2022 at 13:50, Mark Kettenis wrote: > > > From: Simon Glass > > Date: Fri, 11 Feb 2022 13:29:15 -0700 > > > > Hi Mark, > > > > On Fri, 11 Feb 2022 at 13:00, Mark Kettenis wrote: > > > > > > The address of the debug UART varies differs between the M1 and > > > the M1 Pro/Max SoCs. So we have to disable it to make a single > > > U-Boot binary that works on all SoC generations. Leave the > > > settings for the base address and clock rate of the M1 in place > > > to make it easier to re-enable the debug UART when needed. > > > > How about adding some docs about how to, and what the addresses are? > > Yes I can do that. A section at the end of doc/board/apple/m1.rst? > Is it ok if I provide a single update to that file for the M1 Pro/Max > support? Sounds right, just enough to explain how to enable it. Regards, Simon > > > > Signed-off-by: Mark Kettenis > > > --- > > > configs/apple_m1_defconfig | 1 - > > > 1 file changed, 1 deletion(-) > > > > > > diff --git a/configs/apple_m1_defconfig b/configs/apple_m1_defconfig > > > index ef5b7ffd1a..396fe63114 100644 > > > --- a/configs/apple_m1_defconfig > > > +++ b/configs/apple_m1_defconfig > > > @@ -3,7 +3,6 @@ CONFIG_ARCH_APPLE=y > > > CONFIG_DEFAULT_DEVICE_TREE="t8103-j274" > > > CONFIG_DEBUG_UART_BASE=0x235200000 > > > CONFIG_DEBUG_UART_CLOCK=24000000 > > > -CONFIG_DEBUG_UART=y > > > CONFIG_SYS_LOAD_ADDR=0x0 > > > CONFIG_USE_PREBOOT=y > > > # CONFIG_DISPLAY_CPUINFO is not set > > > -- > > > 2.35.1 > > > > > > > Regards, > > SImon > >