From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Glass Date: Sat, 1 Apr 2017 18:05:34 -0600 Subject: [U-Boot] [PATCH 4/6] net: gmac_rockchip: Add support for the RK3399 GMAC In-Reply-To: References: <1490379869-47505-1-git-send-email-philipp.tomsich@theobroma-systems.com> <1490379869-47505-5-git-send-email-philipp.tomsich@theobroma-systems.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 26 March 2017 at 07:52, Joe Hershberger wrote: > On Sat, Mar 25, 2017 at 11:48 PM, Simon Glass wrote: >> On 25 March 2017 at 13:09, Joe Hershberger wrote: >>> On Fri, Mar 24, 2017 at 2:24 PM, Philipp Tomsich >>> wrote: >>>> The GMAC in the RK3399 is very similar to the RK3288 variant (i.e. it >>>> is a Designware GMAC core and requires similar configuration as the >>>> RK3288 to switch it to RGMII and set up the TX/RX delays for Gigabit). >>>> The key difference is that the register offsets (within the GRF block) >>>> and bit-offsets (within those registers) used to hold the configuration >>>> differ between the various RK32/33 CPUs. >>>> >>>> This change refactors the gmac_rockchip.c driver to use a function >>>> table (selected via driver_data) to factor our these differences. Each >>> >>> Typo: "factor out". >>> >>>> function's implementation then matches the underlying processor. >>>> >>>> Some collateral changes are needed in the definitions describing the >>>> bits and offsets in the GRF are needed to prefix each set of symbolic >>>> constants with the SoC name to avoid name clashes... and in doing so, >>>> the shifts for masks and constants have been moved into the header >>>> files for readability (and to make it easier to stay below 80 chars). >>>> >>>> X-AffectedPlatforms: RK3399-Q7 >>>> Signed-off-by: Philipp Tomsich >>>> Tested-by: Klaus Goger >>> >>> Acked-by: Joe Hershberger >> >> Acked-by: Simon Glass >> >> I can fix the typo when applying if there are no other comments. > > Sounds good - go for it. > > -Joe Fixed, and: Applied to u-boot-rockchip, thanks!