From mboxrd@z Thu Jan  1 00:00:00 1970
From: Simon Glass <sjg@chromium.org>
Date: Sat, 28 Mar 2020 14:58:12 -0600
Subject: [PATCH] x86: spi: Only use the fast SPI peripheral when support
In-Reply-To: <CAEUhbmXw2u6Xqy+vV+ywXusp8EOSbEUxs0XW8mHtDhbgnVwJBw@mail.gmail.com>
References: <20200324074524.1.Ibc9c511db58caa8a1e4c56d7e7824d7690718aeb@changeid>
 <CAEUhbmXe4nZQrsmonpmeQ6Be=zf+J6SRXGcRGZ7GvSkzycLEqQ@mail.gmail.com>
 <CAPnjgZ0T1yRsuCv9yCysG9ykPA2fF6fYPD=KTjC2_Rt0t8pXzA@mail.gmail.com>
 <CAEUhbmXw2u6Xqy+vV+ywXusp8EOSbEUxs0XW8mHtDhbgnVwJBw@mail.gmail.com>
Message-ID: <CAPnjgZ0A73=GwrCfjVPq1=9ax3VzGGkDaRZMpVqzMoVAchYYLA@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Bin,

On Thu, 26 Mar 2020 at 10:38, Bin Meng <bmeng.cn@gmail.com> wrote:
>
> Hi Simon,
>
> On Fri, Mar 27, 2020 at 12:20 AM Simon Glass <sjg@chromium.org> wrote:
> >
> > HI Bin,
> >
> > On Wed, 25 Mar 2020 at 01:25, Bin Meng <bmeng.cn@gmail.com> wrote:
> > >
> > > Hi Simon,
> > >
> > > On Tue, Mar 24, 2020 at 9:45 PM Simon Glass <sjg@chromium.org> wrote:
> > > >
> > > > At present we query the memory map on boards which don't support it. Fix
> > > > this by only doing it on Apollo Lake.
> > > >
> > >
> > > I wonder isn't this check already covered in mrccache_get_region() below:
> > >
> > > ret = dm_spi_get_mmap(dev, &map_base, &map_size, &offset);
> > > if (!ret) {
> > > entry->base = map_base;
> > > } else {
> > > ret = dev_read_u32_array(dev, "memory-map", reg, 2);
> > > if (ret)
> > > return log_msg_ret("Cannot find memory map\n", ret);
> > > entry->base = reg[0];
> > > }
> >
> > Yes it is, so long as dm_spi_get_mmap() returns an error, as it does
> > with my patch.
>
> So does ich_get_mmap_bus() returns 0 on chromebook_link?

Well on link the SPI peripheral is not a PCI device but a child of the
PCH. It is possible to read the registers but at present this only
works once you have the mmio_base (i.e. the PCH device is probed).
This function needs to work before probing (since FSP-S access needs
to happen without probing PCI).

I suspect it would be possible to read the PCH base without probing
it, but it does add quite a bit of special-case code. What do you
think?

Regards,
Simon