From mboxrd@z Thu Jan  1 00:00:00 1970
From: Simon Glass <sjg@chromium.org>
Date: Mon, 14 May 2018 13:53:46 -0600
Subject: [U-Boot] [PATCH 2/2] PCI: autoconfig: Don't allocate 64-bit
 addresses to 32-bit only resources
In-Reply-To: <20180514163813.1219-2-tuomas.tynkkynen@iki.fi>
References: <20180514163813.1219-1-tuomas.tynkkynen@iki.fi>
 <20180514163813.1219-2-tuomas.tynkkynen@iki.fi>
Message-ID: <CAPnjgZ0B1iq-miAThsKfzwVgovt-fOnr+_=UE5y0VoeZVR3dWw@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Tuomas,

On 14 May 2018 at 10:38, Tuomas Tynkkynen <tuomas.tynkkynen@iki.fi> wrote:
> Currently, if we happen to allocate an address requiring 64 bits to a
> device only supporting 32-bit BARs, the address eventually gets silently
> truncated to 32 bits. Avoid this by adding a new flag to
> pciauto_region_allocate() to bail out in such situations.
>
> Signed-off-by: Tuomas Tynkkynen <tuomas.tynkkynen@iki.fi>
> ---
>  drivers/pci/pci_auto.c        | 6 ++++--
>  drivers/pci/pci_auto_common.c | 7 ++++++-
>  drivers/pci/pci_auto_old.c    | 5 +++--
>  include/pci.h                 | 2 +-
>  4 files changed, 14 insertions(+), 6 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

Please can you add a function comment to pciauto_region_allocate()?

Regards,
Simon