From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D37C6C433EF for ; Wed, 9 Mar 2022 02:34:39 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BBEF383976; Wed, 9 Mar 2022 03:34:37 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="ZNJbETRJ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id EE33A83937; Wed, 9 Mar 2022 03:34:35 +0100 (CET) Received: from mail-vs1-xe33.google.com (mail-vs1-xe33.google.com [IPv6:2607:f8b0:4864:20::e33]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 20A5183976 for ; Wed, 9 Mar 2022 03:34:31 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-vs1-xe33.google.com with SMTP id d64so804192vsd.12 for ; Tue, 08 Mar 2022 18:34:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=PZhYoxR1YUKy5V7W/Oy5BLPf/lZt4ah4pDsy9iPS2TA=; b=ZNJbETRJZJlC2xyZeubqNCbguxzEndeyjcKdL4cKJ+GdEMVp4pbKCfZt1rWx2LGkl7 37wCzafJLZjSpYJohBjZVE1iQDU0UMJ9FyeWJSoRkWKiVyVDIJFnxmTkWf6dA4LmpvuP utSYg+75T0QmDKTKUee9BtepUDdUijy9gYL+E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=PZhYoxR1YUKy5V7W/Oy5BLPf/lZt4ah4pDsy9iPS2TA=; b=1qMmvDAZb1SAeMs04ApTH4Zx8UGAM+tG+Feu9CjjGhs3gmAsOjVmlzHS1rk4Vn+jk2 y6xI3g5UTeR0zFElGw9VLLClyjM6yq7f0P2B+9NgF9Lj+HbrKJHhXWapGFFSFJfd7Sd2 JhztcyARmSIfghew4IH+t5uE/qdY9H3J5aTBeMuR860Ad6PyScz0Oyza6wKyRfl3ndq5 5rU4irFRbRRtLjww5YG3lGGA38i5WcypCdHWwRzq7t4IZBBIsNJ+i8PMVBuj7fgXMaYv CpauNRP7qDh8MeIDP+EHPpFlnMVyc8L9+vGjz0NiWuP5nBGa5IS5sV1BubFuD3VBHnco jM1A== X-Gm-Message-State: AOAM532Xla/KZNZo/WnZeDjkjB5WOZnQGFwXEufbnVdxf7K7XnKEuLdM A466gJFgwjcKI4Xt6gyZcGqXuvdaLxeLYiwf76hkwg== X-Google-Smtp-Source: ABdhPJzuRe/HihOd9zysFQMv3ueh9MoKYAXKBkuoSNaPWsIJ/UWSp+tQxk5k3+m7QiFdIDmcpS1haMG3blEjrjS/Pb0= X-Received: by 2002:a67:1a02:0:b0:320:a51f:8067 with SMTP id a2-20020a671a02000000b00320a51f8067mr7164714vsa.38.1646793269642; Tue, 08 Mar 2022 18:34:29 -0800 (PST) MIME-Version: 1.0 References: <20220308113657.221101-1-takahiro.akashi@linaro.org> <82d88a69-159a-257d-2fcb-b6226bff6fe4@gmx.de> <20220309021006.GA136899@laputa> In-Reply-To: <20220309021006.GA136899@laputa> From: Simon Glass Date: Tue, 8 Mar 2022 19:34:15 -0700 Message-ID: Subject: Re: [PATCH v3 00/19] efi_loader: more tightly integrate UEFI disks to driver model To: AKASHI Takahiro , Heinrich Schuchardt , Simon Glass , Masami Hiramatsu , U-Boot Mailing List , Lukasz Majewski , Peng Fan , Bin Meng , Jaehoon Chung , Stefan Roese , Ilias Apalodimas Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Hi Takahiro, On Tue, 8 Mar 2022 at 19:10, AKASHI Takahiro wrote: > > Heinrich, Simon, > > On Tue, Mar 08, 2022 at 05:49:13PM +0100, Heinrich Schuchardt wrote: > > On 3/8/22 12:36, AKASHI Takahiro wrote: > > > With this patch set[1] applied, UEFI subsystem maintains a list of its > > > disk objects dynamically at runtime based on block device's probing. > > > (See "issues" below.) > > > > > > [1]https://github.com/t-akashi/u-boot/tree/efi/dm_disk > > > > This series together with Simon's series breaks multiple boards due to > > size constraints: > > > > https://source.denx.de/u-boot/custodians/u-boot-efi/-/pipelines/11197 > > > > Please, investigate how to work around this issue. > > I have already mentioned this size issue in my cover-letter > in order to let reviewers aware of it and discuss a possible solution: > > ===8<=== > Issues: > ======= > * The image size of U-Boot may increase. CI build test complains, > for instance, > rcar3_salvator-x: > "u-boot.img exceeds file size limit: ... excess: 0x79c bytes" > phycore-rk3288: > "SPL image is too large (size 0x8800 than 0x8000)" > > See [2]. > > [2] https://dev.azure.com/u-boot/u-boot/_build/results?buildId=3770&view=results > ===>8=== > > I have dug into rcar3_salvator-x case; I removed *all* the commits > in this series and yet enabled CONFIG_EVENT, CONFIG_EVENT_DYNAMIC > and CONFIG_DM_EVENT, which are all required for enabling my patch, > with Simon's patch applied on top of v2022.04-rc3. > > Then I still see this size problem: > ===8<=== > ... > MKIMAGE u-boot.img > u-boot.img exceeds file size limit: > limit: 0x100000 bytes > actual: 0x100036 bytes > excess: 0x36 bytes > ===>8=== > > So I have no way to deal with it. > > FYI, the combination of EVENT, EVENT_DYNAMIC and DM_EVENT will > increase the binary size by up to 0x1b2 for rcar3_salvator-x and > it seems the binary has almost already reached its maximum size > even now. So you do need EVENT_DYNAMIC? Does it make sense to make enabling the partition support an option, instead of mandatory? Regards, Simon