From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Glass Date: Thu, 24 May 2018 20:41:39 -0600 Subject: [U-Boot] [PATCH v3 2/3] misc: uclass: Add enable/disable function In-Reply-To: <20180523140734.17608-2-mario.six@gdsys.cc> References: <20180523140734.17608-1-mario.six@gdsys.cc> <20180523140734.17608-2-mario.six@gdsys.cc> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Mario, On 23 May 2018 at 08:07, Mario Six wrote: > Add generic enable/disable function to the misc uclass. > > Signed-off-by: Mario Six > > --- > > v2 -> v3: > * Now return old state from misc_set_enabled > > v1 -> v2: > * Merged the two functions into one function > * Explained the semantics of enabling/disabling more throughly > > --- > drivers/misc/misc-uclass.c | 10 ++++++++++ > include/misc.h | 27 +++++++++++++++++++++++++++ > 2 files changed, 37 insertions(+) > Reviewed-by: Simon Glass Can you please add a simple dm test for the misc device? Or if drivers/mailbox/sandbox-mbox-test.c is sufficient, update it? Regards, Simon