From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8EE28C19F2D for ; Tue, 9 Aug 2022 19:52:20 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 275AE84AC8; Tue, 9 Aug 2022 21:51:42 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="MhTGvP8c"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B6F6284ABF; Tue, 9 Aug 2022 21:51:31 +0200 (CEST) Received: from mail-yb1-xb2e.google.com (mail-yb1-xb2e.google.com [IPv6:2607:f8b0:4864:20::b2e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 851E084AB6 for ; Tue, 9 Aug 2022 21:51:28 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-yb1-xb2e.google.com with SMTP id 21so20044582ybf.4 for ; Tue, 09 Aug 2022 12:51:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=2r3L660rzpUO/+HOAP96TQvMkox5EYhGrK2EIKOJ+Po=; b=MhTGvP8ciKkfbuBEzE2Nrzvz4QBHyoJVLTL96FLMhPdOcXjj92XBZv9YXlf6c9iuRQ 7vuV6zbHyjMfxd/a07j8xoS2HBbNGN2pAh7qeLbmlRuvBhWGGojdKBr5DGAfWvUkE6Qi UDcpwmU++UZQwvSSXhJZZXpco7okA/qbmMths= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=2r3L660rzpUO/+HOAP96TQvMkox5EYhGrK2EIKOJ+Po=; b=vrE5eXN39BlpRrM/r/023tcRlJta5xYgIQisnQOm8dx7bcZfQ82AtpMlk0ZhP+GmqC yInCWylo/r33kD7tQNeUg8h5YvxQZJSpchihQHkoRE1PAYo2bQay5+sVy4M+7r4jdZVT 4WJm0Kex2aIzmksPJbIPt0k3KR1AzYpjj9JzLzdzLJCW9bc6bFkoI40sFRcHwqDSHycq 2KL2uA0k9WMeiSWkFcSEF9f1N94t7zfN3gvIFVRq51+8i+laYMSTOT+vBCsWFz2udYtc ML+ukQFjGfszbs6wIP3aGslVq7QV/1JBEUwYHtuJ7f+RbYTKuFqLGJ5f5tdqaaw8gkdY Ur6Q== X-Gm-Message-State: ACgBeo0MJ02qBvJ7vYxDynmLXsAoWckJoUnKS68pGRGcnoEFpHAsFJjG nZcmeJQCFzKAc0xRWAuUGijcUEVm6xNIEZPhcPh03A== X-Google-Smtp-Source: AA6agR6RKUqLzH0icbU89qJ1/BG4ihgoj3+DXtLHsKSerT8OFIuSbD4UmrFFILQb6xmx3E0Z0S5npIYzcgv5LXxsQ6Y= X-Received: by 2002:a25:a41:0:b0:673:746:76ef with SMTP id 62-20020a250a41000000b00673074676efmr22438862ybk.132.1660074685751; Tue, 09 Aug 2022 12:51:25 -0700 (PDT) MIME-Version: 1.0 References: <20220803181309.29999-1-sjg@chromium.org> <20220803121301.v3.2.Ib592f574bd629316a4da239b054fdad8af2658a3@changeid> <20220808160929.GT1146598@bill-the-cat> In-Reply-To: <20220808160929.GT1146598@bill-the-cat> From: Simon Glass Date: Tue, 9 Aug 2022 13:51:13 -0600 Message-ID: Subject: Re: [PATCH v3 2/2] ci: Add a test for a non-LTO build To: Tom Rini Cc: U-Boot Mailing List , AKASHI Takahiro , Bin Meng Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi Tom, On Mon, 8 Aug 2022 at 10:09, Tom Rini wrote: > > On Sun, Aug 07, 2022 at 09:48:01AM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Wed, 3 Aug 2022 at 12:13, Simon Glass wrote: > > > > > > Check that sandbox builds and runs tests OK with LTO disabled. > > > > > > Signed-off-by: Simon Glass > > > --- > > > > > > (no changes since v1) > > > > > > .azure-pipelines.yml | 4 ++++ > > > .gitlab-ci.yml | 7 +++++++ > > > 2 files changed, 11 insertions(+) > > > > > > > Another little snippet - it seems that CI performance for the world > > builds has dropped 20% - 30% with LTO enabled. With tui I used to see > > just over 1 build a second; now it is running at about 0.78 and kaki > > has gone from close to 0.5 to 0.29. > > > > I wonder if ,in CI, we should just build a selection of boards with > > LTO, switching the world builds to non-LTO? The problem is that we may > > hit code size limits in SPL. > > I'm not sure how you're measuring this. We don't enable LTO by default > anywhere other than sandbox, it's opt-in for a few platforms still. I just assumed that is why, since it slows incremental builds down so much. But perhaps something else is going on? I can try to bisect it, I suppose, if I take tui offline for a bit. Regards, Simon