From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0234AC25B08 for ; Wed, 17 Aug 2022 22:45:12 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 45F8B84A4A; Thu, 18 Aug 2022 00:45:00 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="cjsP7LRp"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7E683848AF; Thu, 18 Aug 2022 00:44:56 +0200 (CEST) Received: from mail-yw1-x112a.google.com (mail-yw1-x112a.google.com [IPv6:2607:f8b0:4864:20::112a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 777C984A43 for ; Thu, 18 Aug 2022 00:44:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-yw1-x112a.google.com with SMTP id 00721157ae682-333a4a5d495so159562147b3.10 for ; Wed, 17 Aug 2022 15:44:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc; bh=mn9CYj2IsSGMNFJYCtAaC3JiHyTJFyS1kc85lwujlo8=; b=cjsP7LRpXv80cvrZyRgYmPay4x6U/yB8tHkPM3SA+jJMhw1G18mFHu9ER+4hdaTDld 0QI1kyCgQOOokTwfYSlymYM7AdQ/9teE4VrgDspHNej12OYN91duHCjFoEron8mJOfSu G/3sLIdcLHcOxtv3+4qucCKs6Dv17nfNTEpOE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc; bh=mn9CYj2IsSGMNFJYCtAaC3JiHyTJFyS1kc85lwujlo8=; b=Y9pO8bPUetypKXfW4BHjzZO6Dffap1SbQUfczKGJY9X0EfkzgA3Ewn6ze0/Y4fUYQq QxyF58mD6DCj9wcUXRPdaDaD6KIpUr2aGNzgY6vp4DL4L6l9tAD8I3oLK1TAaFhtV+TO IF00qAIGEYNND5gJYo77sItvLZpi2zajeCc9OlGEx3SWo3HJotj+heN21NuzP92lAyI6 t5BlbviZOKQIbHiwsq1pKUMT2nL6YVfVaRWHgos6WnlZ9XCyOCdjioW3BwV+6EhEb71x 7ckVuNkxWfiA8HPer7iJlVaoOuJ6whL5NS/+N9lVeKp/BObpecKuVScrY3wy2GcarHQS U8XQ== X-Gm-Message-State: ACgBeo1ZrYCIOE0IAzPKjT4MJqORC9OSlGCpSDwE9N0H+iLAtAb8ja5z ze4tPE2nwvxRMI7qZwgsJ+285Tbu++sOlmaybMJqXg== X-Google-Smtp-Source: AA6agR4gK8GzSIJ1iIbJgxKAhC2yCV3MO3itweZXz1/rzxEMCIPpj7E9wcxG8t1wmmJ3K/JWNJ/BfTc/C0DC7h/HLLI= X-Received: by 2002:a81:1c4c:0:b0:335:2a5d:bd45 with SMTP id c73-20020a811c4c000000b003352a5dbd45mr301328ywc.355.1660776291991; Wed, 17 Aug 2022 15:44:51 -0700 (PDT) MIME-Version: 1.0 References: <20220801154220.20068-1-pali@kernel.org> <20220801154220.20068-2-pali@kernel.org> <20220801193900.zpbunhwopisefjjh@pali> <20220801231546.GY1146598@bill-the-cat> <20220803112801.6edejzme3lrsu77k@pali> <20220817210715.5w6hmzlm2d24jgcb@pali> In-Reply-To: <20220817210715.5w6hmzlm2d24jgcb@pali> From: Simon Glass Date: Wed, 17 Aug 2022 16:44:39 -0600 Message-ID: Subject: Re: [PATCH 2/2] Makefile: Build final mpc85xx non-SPL image in standard file u-boot.bin To: =?UTF-8?Q?Pali_Roh=C3=A1r?= Cc: Tom Rini , U-Boot Mailing List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi, On Wed, 17 Aug 2022 at 15:07, Pali Roh=C3=A1r wrote: > > On Wednesday 03 August 2022 13:28:01 Pali Roh=C3=A1r wrote: > > On Monday 01 August 2022 19:15:46 Tom Rini wrote: > > > On Mon, Aug 01, 2022 at 09:39:00PM +0200, Pali Roh=C3=A1r wrote: > > > > On Monday 01 August 2022 13:13:22 Simon Glass wrote: > > > > > Hi Pali, > > > > > > > > > > On Mon, 1 Aug 2022 at 09:43, Pali Roh=C3=A1r wr= ote: > > > > > > > > > > > > Currently Makefile produces final mpc85xx image when SPL is not= used in > > > > > > custom file u-boot-with-dtb.bin. It is quite confusing name as = build > > > > > > process produce also intermediate file standard file u-boot-dtb= .bin (which > > > > > > is just intermediate and not bootable). Other platforms use u-b= oot.bin > > > > > > (UBOOT_BIN) as standard name for final bootable raw image. > > > > > > > > > > > > So change Makefile rules and binman to produce final bootable f= ile for > > > > > > mpc85xx also into file u-boot.bin. There is just need for mpc85= xx to not > > > > > > define default rule for u-boot.bin then instruct binman (via DT= S file) to > > > > > > store final image into u-boot.bin (instead of u-boot-with-dtb.b= in) and > > > > > > finally rename target u-boot-with-dtb.bin to u-boot.bin. > > > > > > > > > > > > With this change are also removed custom Makefile hacks for mpc= 85xx that it > > > > > > produced non-standard output file. And also updated documentati= on. > > > > > > > > > > > > Signed-off-by: Pali Roh=C3=A1r > > > > > > --- > > > > > > Makefile | 19 +++++-------------- > > > > > > arch/powerpc/dts/kmcent2-u-boot.dtsi | 2 +- > > > > > > arch/powerpc/dts/u-boot.dtsi | 2 +- > > > > > > board/freescale/p1_p2_rdb_pc/README | 2 +- > > > > > > board/freescale/p2041rdb/README | 3 --- > > > > > > board/freescale/t102xrdb/README | 2 +- > > > > > > board/freescale/t104xrdb/README | 2 +- > > > > > > board/freescale/t208xqds/README | 2 +- > > > > > > board/freescale/t208xrdb/README | 2 +- > > > > > > 9 files changed, 12 insertions(+), 24 deletions(-) > > > > > > > > > > At present u-boot.bin has a very standard meaning - it is U-Boot = with the DT. > > > > > > > > > > Boards which need something more than that can/should use binman = to > > > > > create a separate file. > > > > > > > > > > I certainly agree that u-boot-with-dtb.bin is a terrible name, th= ough. > > > > > Something more descriptive would be better. > > > > > > > > > > But is it possible to drop these SoC-specific rules in the Makefi= le > > > > > and just build everything needed in the standard binman rule in t= he > > > > > Makefile? > > > > > > > > > > Regards, > > > > > Simon > > > > > > > > I do not know what is binman doing and how to use it. I just do not= see > > > > reason why it is needed to use such additional tool for building fi= nal > > > > binary for powerpc/mpc85xx as other arm boards do not use it at all= . > > > > > > > > Ad your comment "At present u-boot.bin has a very standard meaning = - it > > > > is U-Boot with the DT." - This is exactly what binman for mpc85xx > > > > produces. > > > > > > > > So I see there could be improvements, but as a first step this my p= atch > > > > should be enough? > > > > > > So, one of the issues with PowerPC stuff is that much of it is so far > > > behind the rest of U-Boot in terms of frameworks. So yes, let us sta= rt > > > by fixing the functional problem you're describing here and then see > > > what appetite exists for further work here. > > > > > > -- > > > Tom > > > > Ok, so these two patches in this patch series is a starting point. > > > > Now I send another patch which does another cleanup in this area: > > https://patchwork.ozlabs.org/project/uboot/patch/20220803112442.4735-1-= pali@kernel.org/ > > PING? I'm not sure what to say here and will leave it to Tom. - Simon