All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: Simon Glass <sjg@chromium.org>
Cc: "Patrick Delaunay" <patrick.delaunay@foss.st.com>,
	"U-Boot Mailing List" <u-boot@lists.denx.de>,
	"Vincent Stehlé" <vincent.stehle@arm.com>,
	"Heinrich Schuchardt" <xypron.glpk@gmx.de>
Subject: Re: [PATCH 1/1] sandbox: fix sandbox_reset()
Date: Sun, 4 Jul 2021 13:15:30 -0700	[thread overview]
Message-ID: <CAPnjgZ0KZu+LYXiZYaFBty_RwY7EYKX3+0RhWQGH-543GRAFFA@mail.gmail.com> (raw)
In-Reply-To: <CAPnjgZ11O2yjLCgg3-nsKUoQ2HHaCipG-MziTcH4Aq4AdS_hiw@mail.gmail.com>

On Wed, 12 May 2021 at 10:39, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>
> state_uninit() and dm_uninit() are mutually exclusive:
>
> state_uninit() prints via drivers. So it cannot be executed after
> dm_uninit().
>
> dm_uninit() requires memory. So it cannot be executed after state_uninit()
> which releases all memory.
>
> Just skip dm_uninit() when resetting the sandbox. We will wake up in a new
> process and allocate new memory. So this cleanup is not required. We don't
> do it in sandbox_exit() either.
>
> This avoids a segmentation error when efi_reset_system_boottime() is
> invoked by a UEFI application.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>  arch/sandbox/cpu/start.c | 3 ---
>  1 file changed, 3 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot-dm/next, thanks!

      parent reply	other threads:[~2021-07-04 20:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-12 16:38 [PATCH 1/1] sandbox: fix sandbox_reset() Heinrich Schuchardt
2021-05-12 17:53 ` Vincent Stehlé
2021-05-15 15:20 ` Simon Glass
2021-07-04 20:15 ` Simon Glass [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPnjgZ0KZu+LYXiZYaFBty_RwY7EYKX3+0RhWQGH-543GRAFFA@mail.gmail.com \
    --to=sjg@chromium.org \
    --cc=patrick.delaunay@foss.st.com \
    --cc=u-boot@lists.denx.de \
    --cc=vincent.stehle@arm.com \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.