From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D2C0DC433FE for ; Mon, 10 Oct 2022 15:43:20 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B791C84967; Mon, 10 Oct 2022 17:43:18 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="jReuyto7"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4F05184EE8; Mon, 10 Oct 2022 17:43:16 +0200 (CEST) Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7A9918493F for ; Mon, 10 Oct 2022 17:43:13 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-wr1-x42a.google.com with SMTP id r13so17608431wrj.11 for ; Mon, 10 Oct 2022 08:43:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=dVy3D0K0qAma/kWC7ricE6ExYmaqZKNbtRfDfSUFL2k=; b=jReuyto7ZTx3hwq3BJP4YhyuH9rQTGCmMAr6mSJYIf/XqSZEUGRzkxGwMQEkvK8Bob H5D6mq5cMvB1tY0hKzsahlNj+LaNWwMYN5JlRSbPIvSgrwAcfvqZj95dsBnrVBWoYtXf GhhPjghyTMAOH2amsZr10/bxXZ31h9BDBFFCc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dVy3D0K0qAma/kWC7ricE6ExYmaqZKNbtRfDfSUFL2k=; b=QUlGHk0kn6LC7g6yUkZRNY8l48tRCCpHfoTw5w7Dt7j/vPrgJ69PVGL1tFOvxXbrve 0prau64px+LkvI6NPMkpw+8LnPfortNDRolseLIEiaWqH0yvWh+j7D/tr2C79ZHawpOB cFEfsWevk9C2ytAHH2AgV44PjDVgz106bf+z/puknqyV0vdX0lDKtaotnD5t4DaMCzGJ /NhhtdctgMHogApNY0uwf9NxDq/AMxM5nZV2x5KFpdJ96RPMyYfPOIv2B5s4k0Jhcvn1 1ej4wBWXCPw5fwpaMK0wHAVU5ocPlbQ5Vb0cfZVDZGKuVlV6qQIWvjLOrqW5aLsvUOyX /yEA== X-Gm-Message-State: ACrzQf21xUuBFZDklTp/4+G9p2bZxl9rCa5xCMiWKnU3La8AiYfXehzD f/+p98+bfmHWGWAL0zd/mNvL/8d+wWj1IkzuUfHbRw== X-Google-Smtp-Source: AMsMyM5JVOtvhHvXuPm3w4YZP+oxloKF0jASTe1duPBat0Y+ARIF9YKWsIu4oa0AL7JhCCOAoGRlWLhcK1g54BfzTnM= X-Received: by 2002:a5d:55d0:0:b0:231:2304:3a6a with SMTP id i16-20020a5d55d0000000b0023123043a6amr1070451wrw.94.1665416592784; Mon, 10 Oct 2022 08:43:12 -0700 (PDT) MIME-Version: 1.0 References: <20220110031413.1970836-1-sjg@chromium.org> <20220110031413.1970836-2-sjg@chromium.org> <618ffc64-3880-393b-e13c-0908d8b577ad@prevas.dk> <20221010152413.GH2020586@bill-the-cat> <20221010153629.GI2020586@bill-the-cat> In-Reply-To: <20221010153629.GI2020586@bill-the-cat> From: Simon Glass Date: Mon, 10 Oct 2022 09:43:01 -0600 Message-ID: Subject: Re: [PATCH v2 01/38] Makefile: Fake external blobs by default with binman To: Tom Rini Cc: Rasmus Villemoes , U-Boot Mailing List , Masahiro Yamada Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi Tom, On Mon, 10 Oct 2022 at 09:36, Tom Rini wrote: > > On Mon, Oct 10, 2022 at 09:33:59AM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Mon, 10 Oct 2022 at 09:24, Tom Rini wrote: > > > > > > On Mon, Oct 10, 2022 at 09:19:39AM -0600, Simon Glass wrote: > > > > Hi Rasmus, > > > > > > > > On Mon, 10 Oct 2022 at 04:16, Rasmus Villemoes > > > > wrote: > > > > > > > > > > On 10/01/2022 04.13, Simon Glass wrote: > > > > > > This behaviour is necessary with boards where the binman description > > > > > > requires processing external blobs, since these may be missing. > > > > > > > > > > > > Enable it by default, so that CI is happy. Warnings indicate that a valid > > > > > > image is not produced, as with the --allow-missing option. > > > > > > > > > > I know I have talked and warned about this before, and now I was > > > > > actually bitten by it IRL. > > > > > > > > > > Can we _please_ stop doing this by default. I understand why upstream > > > > > U-Boot's CI system needs this, but it should be possible for that CI > > > > > system to set an environment variable or pass a make parameter to opt-in > > > > > to generating these fake blobs. > > > > > > > > > > Generating potentially non-functional binaries by default, and currently > > > > > without even a way to opt out of that (that I have found), is frankly > > > > > not sane. Yeah, a warning is printed, but that easily scrolls away or in > > > > > the case of automated builds is hidden away in some log file people > > > > > would only ever look at if the job failed. > > > > > > > > > > I want my/our CI to _fail hard_ when I have failed to update the Yocto > > > > > metadata to stage the necessary blobs before do_compile. And if upstream > > > > > U-Boot want to continue to have this by default, can we at the very > > > > > least get an ergonomic way to opt out (preferably a CONFIG_ option I can > > > > > set or clear in my out-of-tree defconfig files). > > > > > > > > How come it doesn't fail? Building should produce an error 101 in this > > > > case. Does it not? Please send the details if there is something > > > > wrong. > > > > > > No, it does not. You can see this for example with: > > > $ make galileo_config > > > ... > > > $ make -sj16 > > > Image 'main-section' is missing external blobs and is non-functional: intel-cmc > > > Image 'main-section' has faked external blobs and is non-functional: rmu.bin > > > > > > Some images are invalid > > > $ echo $? > > > 0 > > > > Ah OK, that is a bug, though. I suppose I normally use buildman so > > don't see it, and we have no test for it. > > > > I'll take a look when I get the -N thing done. > > Well, it's a design feature that buildman shows too. See the series I > just posted, we've been unconditionally passing binman the flags to > always allow and fake missing binaries. Yes, I see it. Will take a look after N: Regrads, Simon