From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2CDE6C433F5 for ; Thu, 13 Jan 2022 18:03:31 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 56383835FB; Thu, 13 Jan 2022 19:01:31 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="H+c7I1YO"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A601B83420; Thu, 13 Jan 2022 19:01:04 +0100 (CET) Received: from mail-ua1-x933.google.com (mail-ua1-x933.google.com [IPv6:2607:f8b0:4864:20::933]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0BF118341B for ; Thu, 13 Jan 2022 19:00:57 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-ua1-x933.google.com with SMTP id c36so12572961uae.13 for ; Thu, 13 Jan 2022 10:00:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:sender:from:in-reply-to:references:date:message-id :subject:to:cc; bh=9YD/ky6w5Ipaq/etDnkAouQxdbkcMEqHGSAeBeVq+LE=; b=H+c7I1YOjJcC5Gyptjwwld07pzEUjSqoOmSa1RE2eNHvlBjPyHmD8UhkMXCKZnS3RN Own3lOqZLdJ9RjW2bvxyZS4IRO/cYGX7g5ckOpzMHWsflHmVoE3ae/LnbMZQl5YCwmxi E6oVFL6IhGaePjdnD518k7U+KNjVzIwqxmDXY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:sender:from:in-reply-to:references :date:message-id:subject:to:cc; bh=9YD/ky6w5Ipaq/etDnkAouQxdbkcMEqHGSAeBeVq+LE=; b=bIlhQjd3GoaSXxKl0ealracLdzm1JC2r4MvYyEb6IQNH1zNinIFB3netWOQ6tVI1hB ZPi8tog9WC5SjcFu0yMBhMeEXULTkKNEw06pDQjWqvd4If9R6M019IrXGlO7TDstMoai jmETIdex7eYKQrmmDZC+hRs4f9UBZqvGQfkhLXG07Q25unabOsuMxIZG/jTxW62ZjIAx ir0zFk4wmnAslkISF2Vhs0YIT0IvbFP7ZbNLuGLU4HmKPah8bgURHS5BdZgirZ7bkfWf bIzJYtCty4T9EoAmXJjI2+3ncdynMW+CuV327z/PLRwjZFB3i3epkCLLLWfQr/PCMtl3 fNQg== X-Gm-Message-State: AOAM533FWSmda/CXkKdC4Qzm1HkOanzXtUixYGe8cA9OJ0rNswf4mXZ3 /HSjDCDONVs/y9pGj4LbcNsg3PHYjnEmzCBSI2307Y/NHao= X-Google-Smtp-Source: ABdhPJzhPwf9olPvkYCS6rgPcU7kUakKH185+VsDCj3lVPlhJZlYZOy1SvKmM4vPHwtUeWPhMUT6cE09+rrl9yROqw0= X-Received: by 2002:ab0:6d85:: with SMTP id m5mr2808729uah.140.1642096855545; Thu, 13 Jan 2022 10:00:55 -0800 (PST) Received: from 480794996271 named unknown by gmailapi.google.com with HTTPREST; Thu, 13 Jan 2022 10:00:54 -0800 MIME-Version: 1.0 From: Simon Glass In-Reply-To: References: <85e7e0be34d30b100c7bb419f801a8c2e22fd1e9.1641569887.git.michal.simek@xilinx.com> Date: Thu, 13 Jan 2022 10:00:54 -0800 X-Google-Sender-Auth: p9WLlt7B6iXRwrUnd145Q3lO9b0 Message-ID: Subject: Re: [PATCH] dm: core: Switch order of pinctrl and power domain calls To: Simon Glass Cc: U-Boot Mailing List , git , Michal Simek Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Fri, 7 Jan 2022 at 08:38, Michal Simek wrote: > > The commit 3ad307784847 ("dm: core: device: enable power domain in probe") > introduced enabling power domain when device is probed. > By checking this sequence in Linux kernel was found that power domain is > handled first followed by pinctrl setting. > > This patch is switching this order to follow Linux kernel that power > domains are handled first follow by pinctrl setting. > > The issue was found on Xilinx Kria SOM where firmware is blocking setting > up pin configuration/muxes without enabling power domain for the specific > IP first. > > Signed-off-by: Michal Simek > --- > > drivers/core/device.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) Reviewed-by: Simon Glass Applied to u-boot-dm, thanks!