From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1E5DDC25B50 for ; Fri, 20 Jan 2023 19:46:22 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 503D4854D8; Fri, 20 Jan 2023 20:46:20 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="czEODKXv"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3266F854C5; Fri, 20 Jan 2023 20:46:19 +0100 (CET) Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B1D0285203 for ; Fri, 20 Jan 2023 20:46:16 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-ej1-x62f.google.com with SMTP id hw16so16509295ejc.10 for ; Fri, 20 Jan 2023 11:46:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=OVshfiB0iEjr+kEi3X+aIAxTNjOebdW6THcMGiiLO3U=; b=czEODKXvmdjpoIfAN+XFWwvnbAhc3N/Ileij/+G1hp0gjm1IQmJ+8fAaNePCUsPiIY hVkNpm2BB0ANGKQJuNydqVa+7IUMrOcFkEuADGmIe1s2x7sfZG9pos24NZgMmWoCR/EP kRPjDOCjHszRI7kCtCU9rbjVkzg/hcR2CAfC8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OVshfiB0iEjr+kEi3X+aIAxTNjOebdW6THcMGiiLO3U=; b=hpflicjRhNcOcaE+wpvdHPETEm7Rczl9UJL7U4cEepxMMWxtrTdyz+kpTcHooTJmHj cgfF3tb6gDpCf+Ll8eWDtIMhsekB7Xo2g9FuNnXIYuRzMDBOieL5TEDppHKui/kpYDhs B67umlVwi9fo1oX3cj7dIFN7qohJWxl1OK4hr5jKuCX9dFNVHH0O2TY+F2Tu2AhUIHzw 5yFwfrWbGltZ9B0BziZnOZHoBsIhnLQXOie+hXP4fqxaZdVsf6vGwxR9n+vgVCUIRltZ OUJHIKmfKdBSmS9VzRG7K6CZKX/K8VFvfSQDfg/cMpbvvxmlnDEvdTuwRD8ZzGppSwnY c+/w== X-Gm-Message-State: AFqh2krrYl5FqnG0fb8QbDm7wbGhgGKr569rlYVOUH+RaSFVuRHUwKvE P6wUHt7v62iyJHM+WlP3ZsaH8tofSYR4r7KbLYYAEQ== X-Google-Smtp-Source: AMrXdXslmHZLCdDsdec/ALAaIch4/cD6zoBwMpXUQihlfHL21xmfsfiEfvaABvUfIMIiPsIjHwxyTZz21VkKqk+QocQ= X-Received: by 2002:a17:906:ae56:b0:86c:fe1:b97f with SMTP id lf22-20020a170906ae5600b0086c0fe1b97fmr2178554ejb.388.1674243976089; Fri, 20 Jan 2023 11:46:16 -0800 (PST) MIME-Version: 1.0 References: <20230120101903.179959-1-n-francis@ti.com> <20230120101903.179959-14-n-francis@ti.com> In-Reply-To: <20230120101903.179959-14-n-francis@ti.com> From: Simon Glass Date: Fri, 20 Jan 2023 12:46:04 -0700 Message-ID: Subject: Re: [PATCH 13/21] Makefile: Add DM, SYSFW_PATH, SYSFW_HS_INNER_CERT_PATH to BINMAN_INDIRS To: Neha Malcom Francis Cc: u-boot@lists.denx.de, trini@konsulko.com, afd@ti.com, vigneshr@ti.com, rogerq@kernel.org, alpernebiyasak@gmail.com, nm@ti.com, bb@ti.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi Neha, On Fri, 20 Jan 2023 at 03:19, Neha Malcom Francis wrote: > > To remain consistent with the build commands utilised for K3 devices, > we add the paths where component binaries are located to BINMAN_INDIRS. > Adding SYSFW_PATH for system firmware binaries, SYSFW_HS_INNER_CERT_PATH > for HS device certificate and DM for Device Manager firmware. > This way, the existing build command does not change even though we > migrate to using binman. > > Signed-off-by: Neha Malcom Francis > --- > Makefile | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/Makefile b/Makefile > index c568a6e59a..218cb675fc 100644 > --- a/Makefile > +++ b/Makefile > @@ -1317,6 +1317,22 @@ u-boot.ldr: u-boot > # Use 'make BINMAN_VERBOSE=3' to set vebosity level > default_dt := $(if $(DEVICE_TREE),$(DEVICE_TREE),$(CONFIG_DEFAULT_DEVICE_TREE)) > > +ifneq ($(SYSFW_PATH),) > +override BINMAN_INDIRS += $(dir $(SYSFW_PATH)) > +endif > + > +ifneq ($(SYSFW_HS_PATH),) > +override BINMAN_INDIRS += $(dir $(SYSFW_HS_PATH)) > +endif > + > +ifneq ($(SYSFW_HS_INNER_CERT_PATH),) > +override BINMAN_INDIRS += $(dir $(SYSFW_HS_INNER_CERT_PATH)) > +endif > + > +ifneq ($(DM),) > +override BINMAN_INDIRS += $(dir $(DM)) > +endif > + > quiet_cmd_binman = BINMAN $@ > cmd_binman = $(srctree)/tools/binman/binman $(if $(BINMAN_DEBUG),-D) \ > $(foreach f,$(BINMAN_TOOLPATHS),--toolpath $(f)) \ > -- > 2.34.1 > Let's try to do this another way as it needs to use a bintool for the tool that you run. See my other comments. Regards, Simon