From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B45BAC433EF for ; Fri, 7 Jan 2022 01:27:27 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D3DF38317A; Fri, 7 Jan 2022 02:27:24 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="fQUgKfqc"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A6C3B82DA1; Fri, 7 Jan 2022 02:27:23 +0100 (CET) Received: from mail-vk1-xa31.google.com (mail-vk1-xa31.google.com [IPv6:2607:f8b0:4864:20::a31]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7A2C982DA1 for ; Fri, 7 Jan 2022 02:27:19 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-vk1-xa31.google.com with SMTP id h67so2831064vkh.1 for ; Thu, 06 Jan 2022 17:27:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+1mPBb1bP+XqAF1cqjm6YzPCEF5VILivKy9MtRt0XTU=; b=fQUgKfqcAXpuPXpH2HMz0NTP50px+9xYZrVqDVhY41RHKQT6cgjEICMb4ZTjDRc2JB PXbAJ+06LaLncpMp9E7YiMF10Sx9urPxJQIEWmyxkLpqOVvtRQ+q1HoMlxcaFKFM6y+p NfsyXgd67RR86FhJYmMH0r6Cu+HGlSBJcTOek= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+1mPBb1bP+XqAF1cqjm6YzPCEF5VILivKy9MtRt0XTU=; b=I4r1Tct3Eb0HnK6RTbxsB9otW0VL0yorQjO2VJ3nUVArfVLy6M8FwgMGU14Ry0P9kQ NOXDUpuYduWLgRK78/JH8C4Y2yTVKIdpEbtKV6DRJKnsAi/WSCPIlFS3ICeCtrW3e2N9 BzMH0A9KdblrJRneyY3VlXdq6H7yTgxKHCWcDV3eBKz38sfl8drdvOBB087vC1r1/GhD 9/Va+P2WO5nA0H/seKo3kmDFzeGAsw3NF2u1Ed2JFjVTB5m4UsaXdwVEVFOz6Mad8iaK fDOVB57gGPBRcnvV/NlfW2e8eUkUYg+LYllZYEe/PxhsdIw7c3D2zi06Osz3Cy7c2CV/ hVNw== X-Gm-Message-State: AOAM531zxm1MCX06XPWVTxpzYmS9StQfT9IWDQWy6SN5ni6nhWf6KPeS OWNXIw78Et1SLgALOMsRrGdWt9/HovIwHI9uTdhtJw== X-Google-Smtp-Source: ABdhPJyNDrkaRrPfilhPF2ACynztqKAMTyjegO5zJGbwBKCQkOtaQ49uxwtflZZzsmYPsBqg90XJ/eyjyLGIqODScqE= X-Received: by 2002:a1f:2345:: with SMTP id j66mr11135391vkj.16.1641518837783; Thu, 06 Jan 2022 17:27:17 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Simon Glass Date: Thu, 6 Jan 2022 18:27:06 -0700 Message-ID: Subject: Re: mkimage_fit_atf.sh: not found To: Heiko Thiery Cc: Tim Harvey , ZHIZHIKIN Andrey , u-boot , Stefano Babic , Fabio Estevam , Schrempf Frieder , Adam Ford , Marcel Ziswiler , Jagan Teki , Oliver Graute Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Heiko, On Thu, 6 Jan 2022 at 13:44, Heiko Thiery wrote: > > Hi Tim and all, > > Am Do., 6. Jan. 2022 um 18:10 Uhr schrieb Tim Harvey : > > > > On Thu, Jan 6, 2022 at 2:07 AM ZHIZHIKIN Andrey > > wrote: > > > > > > Hello Tim, > > > > > > > -----Original Message----- > > > > From: U-Boot On Behalf Of Tim Harvey > > > > Sent: Wednesday, January 5, 2022 8:08 PM > > > > To: ZHIZHIKIN Andrey > > > > Cc: u-boot ; Stefano Babic ; Fabio Estevam > > > > ; Schrempf Frieder ; Adam Ford > > > > ; Marcel Ziswiler ; Jagan Teki > > > > > > > > Subject: Re: mkimage_fit_atf.sh: not found > > > > > > > > On Wed, Jan 5, 2022 at 3:34 AM ZHIZHIKIN Andrey > > > > wrote: > > > > > > > > > > Hello Tim, > > > > > > > > > > > -----Original Message----- > > > > > > From: U-Boot On Behalf Of Tim Harvey > > > > > > Sent: Tuesday, January 4, 2022 11:48 PM > > > > > > To: u-boot ; Stefano Babic ; Fabio > > > > Estevam > > > > > > > > > > > > Cc: Schrempf Frieder ; Adam Ford > > > > > > ; Marcel Ziswiler ; Jagan Teki > > > > > > > > > > > > Subject: mkimage_fit_atf.sh: not found > > > > > > > > > > > > Stefano and Fabio, > > > > > > > > > > > > I'm seeing the imx8mm_venice_defconfig target failing to build on > > > > > > master due to mkimage_fit_atf.sh not found: > > > > > > ./"arch/arm/mach-imx/mkimage_fit_atf.sh" \ > > > > > > arch/arm/dts/imx8mm-venice-gw71xx-0x.dtb > > > > > > arch/arm/dts/imx8mm-venice-gw72xx-0x.dtb > > > > > > arch/arm/dts/imx8mm-venice-gw73xx-0x.dtb > > > > > > arch/arm/dts/imx8mm-venice-gw7901.dtb > > > > > > arch/arm/dts/imx8mm-venice-gw7902.dtb > u-boot.its > > > > > > /bin/sh: 1: ./arch/arm/mach-imx/mkimage_fit_atf.sh: not found > > > > > > > > > > > > > > > > This has been dropped in d9a6f0eed6 ("tree: imx: remove old fit generator > > > > script") > > > > > > > > So why was that merged when it breaks several boards that are not > > > > switched to binman because of the CI issue? > > > > > > Because the FIT generator script has been broken after commit 3f04db891a > > > ("image: Check for unit addresses in FITs"), which has covered CVE-2021-27138. > > > You can see the reasoning of merging d9a6f0eed6 ("tree: imx: remove old fit > > > generator script") in the commit message. > > > > > > In addition, d9a6f0eed6 ("tree: imx: remove old fit generator script") has > > > been introduced as a part of discussion stemmed from [1], where it has been > > > pointed out that certain boards are still using old FIT generator which is > > > not working, and I've listed those board config files for maintainers to react. > > > > > > > Andrey, > > > > I agree removing the old fit generator is the right path but I am very > > surprised it was merged when it broke boards that had not moved to > > binman yet. There has been a warning to migrate to binman but there > > was never a deadline. > > > > > Binman CI missing binaries verification came later I believe, that is the > > > reason we are seeing those conversions pending. But this is unrelated to the > > > FIT generator script removal, which was broken anyways. > > > > > > > I have not followed the discussion about what was wrong with the FIT > > generator or what was specifically 'broken' but boards at least built > > and booted with it and now they do not build. I do know there was a > > time where I needed a patch that dealt with '@' symbols and I'm not > > sure if that ever got merged before the FIT generator was simply > > removed. Again, I hadn't thought much of it because I had binman > > conversion patches in flight not realizing they would get stuck > > because of CI. > > > > I don't really know anything about U-Boot CI but I'm also surprised it > > doesn't point out the fact that several boards won't currently build. > > > > > > > > > > > > > > > > > As far as I can tell the other boards that are still using > > > > > > SPL_FIT_GENERATOR also fail due to this (ie imx8mm_beacon_defconfig, > > > > > > imx8mq_evk_defconfig, imx8mm-icore-mx8mm-edimm2.2_defconfig, etc). > > > > > > > > > > imx8mq_evk is already converted and I've sent a patch for it, see [1]. > > > > > > > > > > > > > > > > > What is the state of the binman conversion? I submitted a series to > > > > > > convert my boards to binman and it has just been sitting without any > > > > > > response for months now [1]. > > > > > > > > > > I believe that the reason for your series sitting in the queue is the same as > > > > > for imx8mq_evk: missing binary blobs (ATF and DDR) are failing CI builds. > > > > > > > > > > > > > Right, so imx8mq_evk (and others) are completely broken for the > > > > pending release correct? > > > > > > That is correct, and there are patches to address this. > > > > > > There is also a patch series from Heiko to address the "missing binary" CI issue, see [2]. > > > > > > > Again personally I did not pay attention to d9a6f0eed6 ("tree: imx: > > remove old fit generator script") because I already had submitted a > > series to move my board to binman (other boards still had not done > > this however and would be broken without a change). I see that Stefano > > applied d9a6f0eed6 ("tree: imx: remove old fit generator script") on > > Oct 7 and he must not have realized it broke boards that had not moved > > to binman. Several of us have submitted patches to move to binman and > > thus also likely did not notice but those patches never got merged > > because of this CI issue. > > > > I see Heiko has a v4 of his patch here > > https://patchwork.ozlabs.org/project/uboot/list/?series=279595. Can > > that get merged? > > I think applying this patch will not solve the issue finally. This > change will add the ability to fake the needed files (lpddr fw, hdmi > fw ...) by binman with adding the introduced u-boot make option. But > this option has to be set by buildman somehow for the CI. Or we need > to change the default behavior of binman as Simon already proposed. Yes and I will add a patch for that in the series I expect to send soon (which deals with missing binary tools). We do the same for missing binaries, so I think it makes sense. Regards, Simon