Re: [PATCH v2 12/12] rockchip: fix boot_devices constants

From: Simon Glass <sjg@chromium.org>
To: Johan Jonker <jbx6244@gmail.com>
Cc: "Kever Yang" <kever.yang@rock-chips.com>,
	"Philipp Tomsich" <philipp.tomsich@vrull.eu>,
	"U-Boot Mailing List" <u-boot@lists.denx.de>,
	"Wadim Egorov" <w.egorov@phytec.de>,
	"Lin Huang" <hl@rock-chips.com>,
	"Jagan Teki" <jagan@amarulasolutions.com>,
	"Heiko Stübner" <heiko@sntech.de>
Subject: Re: [PATCH v2 12/12] rockchip: fix boot_devices constants
Date: Fri, 11 Mar 2022 19:25:18 -0700	[thread overview]
Message-ID: <CAPnjgZ0Ljy=3MOUpSg93c4jR38fvpTj7qpiJ=B3TOPKjMbWC3A@mail.gmail.com> (raw)
In-Reply-To: <d69824ff-a728-063e-e993-3dbed5a9c98f@gmail.com>

Hi Johan,

On Thu, 3 Mar 2022 at 07:37, Johan Jonker <jbx6244@gmail.com> wrote:
>
> Hi Simon,
>
> Thank you for your test report.
> As I don't always have the hardware, could the board maintainers help me
> identify u-boot specific property differences with Linux that need to be
> moved to a dtsi file.
>
> Will send a new serie with fixes.
>
> Johan
>
> ===
>
> After I sync rk3288.dtsi I get this warning.
> fdt64_t is generated by a script and is not something that I can update
> the regmap_init_mem_plat function for.
> Any advice here?
>
> ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- make chromebook_jerry_defconfig
>
>    CC      spl/drivers/ram/rockchip/sdram_rk3288.o
> drivers/ram/rockchip/sdram_rk3288.c: In function ‘conv_of_plat’:
> drivers/ram/rockchip/sdram_rk3288.c:1032:41: warning: passing argument 2
> of ‘regmap_init_mem_plat’ from incompatible pointer type
> [-Wincompatible-pointer-types]
>   ret = regmap_init_mem_plat(dev, of_plat->reg,
>                                   ~~~~~~~^~~~~
> In file included from drivers/ram/rockchip/sdram_rk3288.c:18:
> include/regmap.h:391:58: note: expected ‘fdt_val_t *’ {aka ‘unsigned int
> *’} but argument is of type ‘fdt64_t *’ {aka ‘long long unsigned int *’}
>  int regmap_init_mem_plat(struct udevice *dev, fdt_val_t *reg, int count,
>
>
> On 3/3/22 04:37, Simon Glass wrote:
> > Hi Johan,
> >
> > On Mon, 28 Feb 2022 at 18:48, Johan Jonker <jbx6244@gmail.com> wrote:
> >>
> >> The DT node name pattern in mmc-controller.yaml for mmc
> >> is "^mmc(@.*)?$". The Rockchip mmc nodes have been synced
> >> with Linux, so update the boot_devices constants as well.
> >>
> >> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> >> Reviewed-by: Simon Glass <sjg@chromium.org>
> >> ---
> >>  arch/arm/mach-rockchip/rk3188/rk3188.c | 4 ++--
> >>  arch/arm/mach-rockchip/rk322x/rk322x.c | 4 ++--
> >>  arch/arm/mach-rockchip/rk3288/rk3288.c | 4 ++--
> >>  arch/arm/mach-rockchip/rk3328/rk3328.c | 4 ++--
> >>  arch/arm/mach-rockchip/rk3368/rk3368.c | 4 ++--
> >>  5 files changed, 10 insertions(+), 10 deletions(-)
> >
>
> > I tested this series on snow and it seems fine.
> >
> > I tried it on jerry and got:
> >
> > DRAM init failed: -19
>
>         noc: syscon@ffac0000 {
>                 compatible = "rockchip,rk3288-noc", "syscon";
>                 reg = <0x0 0xffac0000 0x0 0x2000>;
>
> Forgot something. Does that help or is there more that needs to be fixed?
>
> ==>             u-boot,dm-pre-reloc;

See my other reply for jerry.

I might be able to make my lab available to you somehow.

>
>         };
>
> TODO: Must change/update dmc/noc reg size when I sync rk3288.dtsi.
>
> >
> > It also seemed fine on bob although my display is not coming up, for
> > different reasons.
>
> In SPL or full U-boot?

There is no display in SPL.

>
> rk3288-veyron-chromebook.dtsi:
>
>         aliases {
>                 i2c20 = &i2c_tunnel;
>                 video0 = &vopl;
>                 video1 = &vopb;
>         };
>
> Is this video alias something U-boot specific?
> Fixing U-boot video is beyond my U-boot knowledge.

Well that's OK, just keep the aliases around and perhaps upstream
them? I am not quite sure why we need an ordering for the video,
actually.

Regards,
Simon