From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Glass Date: Mon, 28 Oct 2019 21:32:08 -0600 Subject: [U-Boot] [PATCH v2 1/5] tools: buildman: Honor output directory when generating boards.cfg In-Reply-To: <1572272704-31204-2-git-send-email-bmeng.cn@gmail.com> References: <1572272704-31204-1-git-send-email-bmeng.cn@gmail.com> <1572272704-31204-2-git-send-email-bmeng.cn@gmail.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Bin, On Mon, 28 Oct 2019 at 08:25, Bin Meng wrote: > > buildman always generates boards.cfg in the U-Boot source tree. > When '-o' is given, we should generate boards.cfg to the given > output directory. > > Signed-off-by: Bin Meng > --- > > Changes in v2: None > > tools/buildman/control.py | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > Reviewed-by: Simon Glass Does this preserve existing behaviour when -o is not given? I suppose it doesn't matter so long as buildman uses the right file? > diff --git a/tools/buildman/control.py b/tools/buildman/control.py > index fcf531c..9787b86 100644 > --- a/tools/buildman/control.py > +++ b/tools/buildman/control.py > @@ -201,14 +201,14 @@ def DoBuildman(options, args, toolchains=None, make_func=None, boards=None, > > # Work out what subset of the boards we are building > if not boards: > - board_file = os.path.join(options.git, 'boards.cfg') > - status = subprocess.call([os.path.join(options.git, > - 'tools/genboardscfg.py')]) > + board_file = os.path.join(options.output_dir, 'boards.cfg') > + genboardscfg = os.path.join(options.git, 'tools/genboardscfg.py') > + status = subprocess.call([genboardscfg, '-o', board_file]) > if status != 0: > - sys.exit("Failed to generate boards.cfg") > + sys.exit("Failed to generate boards.cfg") > > boards = board.Boards() > - boards.ReadBoards(os.path.join(options.git, 'boards.cfg')) > + boards.ReadBoards(board_file) > > exclude = [] > if options.exclude: > -- > 2.7.4 > Regards, Simon