From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A419DC433EF for ; Fri, 11 Mar 2022 18:26:38 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id F00B983400; Fri, 11 Mar 2022 19:26:35 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="CspO7t6/"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 39A98811E1; Fri, 11 Mar 2022 19:26:33 +0100 (CET) Received: from mail-vk1-xa2f.google.com (mail-vk1-xa2f.google.com [IPv6:2607:f8b0:4864:20::a2f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id ABCBA83AE0 for ; Fri, 11 Mar 2022 19:26:22 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-vk1-xa2f.google.com with SMTP id az23so5143259vkb.0 for ; Fri, 11 Mar 2022 10:26:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tKs3BEnLNAWR/PxjXuVMQaqaSWTkhVnbS7cR6iKNnaY=; b=CspO7t6/9hwPNpLdnqs5rGuoN2iMgc8MXPO6pQisAQJlo8OSolWsqj8knW77qEAr0l 8Qg74SFJAjj/1Ws4jxbJFhMPNGdbSZ0fQZWteMsY60ZpN0rXdIhvUGsy0AXkV8c5APhT pocapmgJZlMKEUdwJswR4ujP89Bv87PUyg/oA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tKs3BEnLNAWR/PxjXuVMQaqaSWTkhVnbS7cR6iKNnaY=; b=7EANNovwaNh73uG0+bzuDG8l1RdZYNMUp8lPivuAgUfaRDC7RevggPee2YDaoRf8hi Kgld+54uqi4tzgk9ZjrRGZyk8TGCzHiIFQw4YFNHvPfwN7cwY97D5lOM9PvtEZumDaB+ s1Rs4qanPZxKXizrHpAm+uaqqMVkHCEKhTwHTbE+Yu4NVIc64gbhi9OqkOFdfUKZeCe6 8D82+Mvtj9PL8akNJ0pZd9CAl4oKzhEaKVTpZjeLA5kw2TPPDgNgQtusz0LOHFWrOeew xY0zDX6Xvtsy+fBoyLwpR7E9oQNsXV80phkhn5Wdb/K6EhzybOveR+eYr8kgmp0Vxt4Y F9qA== X-Gm-Message-State: AOAM531yxCSGlLTAx1hQfdw8tMCTnXFZfhWHSTQzEQ71n988eA0KY14S 4Sy6GHe/XGiAgC4yWJT+/urnSbiczZdwdoN5S4kAWg== X-Google-Smtp-Source: ABdhPJwC1Pd46OhpP0X/bebggBnTfQHvEWW3CzYL+zsKyragHlsSTRWDl8hAjy7TWn1wrh2Am61Z6H1dqO6+2dNK7eE= X-Received: by 2002:a05:6122:200a:b0:337:540d:265c with SMTP id l10-20020a056122200a00b00337540d265cmr5371846vkd.21.1647023181132; Fri, 11 Mar 2022 10:26:21 -0800 (PST) MIME-Version: 1.0 References: <20220308113657.221101-1-takahiro.akashi@linaro.org> <82d88a69-159a-257d-2fcb-b6226bff6fe4@gmx.de> <6465499b-8c7b-daea-1729-628ed9252eea@web.de> <20220309001314.GQ5020@bill-the-cat> <20220309030035.GR5020@bill-the-cat> <20220309142550.GS5020@bill-the-cat> In-Reply-To: From: Simon Glass Date: Fri, 11 Mar 2022 11:26:08 -0700 Message-ID: Subject: Re: [PATCH v3 00/19] efi_loader: more tightly integrate UEFI disks to driver model To: Tom Rini Cc: Soeren Moch , AKASHI Takahiro , Masami Hiramatsu , U-Boot Mailing List , Lukasz Majewski , Peng Fan , Bin Meng , Jaehoon Chung , Stefan Roese , Ilias Apalodimas , Heinrich Schuchardt Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Hi Tom, Takahiro, On Wed, 9 Mar 2022 at 08:33, Simon Glass wrote: > > Hi Tom, > > On Wed, 9 Mar 2022 at 07:25, Tom Rini wrote: > > > > On Tue, Mar 08, 2022 at 08:10:38PM -0700, Simon Glass wrote: > > > Hi Tom, > > > > > > On Tue, 8 Mar 2022 at 20:00, Tom Rini wrote: > > > > > > > > On Tue, Mar 08, 2022 at 07:32:59PM -0700, Simon Glass wrote: > > > > > Hi Tom, > > > > > > > > > > On Tue, 8 Mar 2022 at 17:13, Tom Rini wrote: > > > > > > > > > > > > On Tue, Mar 08, 2022 at 02:20:15PM -0700, Simon Glass wrote: > > > > > > > Hi Soeren, > > > > > > > > > > > > > > On Tue, 8 Mar 2022 at 12:15, Soeren Moch wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On 08.03.22 17:56, Simon Glass wrote: > > > > > > > > > Hi, > > > > > > > > > > > > > > > > > > On Tue, 8 Mar 2022 at 09:49, Heinrich Schuchardt wrote: > > > > > > > > >> > > > > > > > > >> On 3/8/22 12:36, AKASHI Takahiro wrote: > > > > > > > > >>> With this patch set[1] applied, UEFI subsystem maintains a list of its > > > > > > > > >>> disk objects dynamically at runtime based on block device's probing. > > > > > > > > >>> (See "issues" below.) > > > > > > > > >>> > > > > > > > > >>> [1]https://github.com/t-akashi/u-boot/tree/efi/dm_disk > > > > > > > > >> > > > > > > > > >> This series together with Simon's series breaks multiple boards due to > > > > > > > > >> size constraints: > > > > > > > > >> > > > > > > > > >> https://source.denx.de/u-boot/custodians/u-boot-efi/-/pipelines/11197 > > > > > > > > >> > > > > > > > > >> Please, investigate how to work around this issue. > > > > > > > > > > > > > > > > > > tbs2910 - perhaps we should just drop this board? It doesn't use > > > > > > > > > DM_SERIAL and still uses OF_EMBED > > > > > > > > > > > > > > > > Are we again at the same point? You are breaking working boards with > > > > > > > > (for these boards) useless additions, and all you come up with is > > > > > > > > "remove this board". Of course without adding the board maintainer. > > > > > > > > > > > > > > I'm just expressing reasonable frustration that this board uses > > > > > > > OF_EMBED and does not use DM_SERIAL, after all of this time. Why > > > > > > > should the rest of the U-Boot developers care more about this board > > > > > > > than the maintainer? > > > > > > > > > > > > Please keep in mind Simon that we've had zero releases with the > > > > > > DM_SERIAL migration warning being posted, v2022.04 will be the first > > > > > > one. > > > > > > > > > > Yes, understood :-) For OF_EMBED though...? > > > > > > > > No deadline and 50 boards. > > > > > > Er, there has been a build message about that since the beginning, so > > > people ignored it. Do we really need to make the build fail for these > > > sorts of things? Perhaps so, but it is a sad situation. > > > > Yes, in hind-sight, "don't do that" wasn't the right path. It would be > > a good idea to start a different thread and see what / how the platforms > > can be migrated away. > > I think there is a use case for it now - e.g. booting Apple M1 which > uses a separate bootloader. IMO a .img or .fit file would be better in > some cases but people seem to be allergic to implementing U-Boot > things in their code bases. We have the same requirement for the EFI > app since UEFI does not implement the U-Boot .img file. > > So if we are going to support this, perhaps we should create a new > option for it. But honestly I am just too weary to consider yet > another migration. We need to finish some, e.g. Kconfig. Back to the original topic, I found that some partition code is present in SPL and cannot be dropped. This is a long-standing thing but matters a little more now that there is a driver and blk_post_probe() contains some code. This series is foundational in two ways: - adding driver model support for partitions - starting the clean-up of the EFI code to better use drive rmodel Heinrich, can we please hold off on any new EFI changes in -next until we can get this series landed? Any conflicts will set us back again. I will see if I can send a little series to clean that up and to reduce the board sizes for the non-SPL problems. With that, perhaps we can apply both series within a few days? [..] Regards, Simon