From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Glass Date: Fri, 16 Nov 2018 09:24:52 -0800 Subject: [U-Boot] [PATCH] serial: ns16550: add setconfig support In-Reply-To: References: <20181102202808.5281-1-simon.k.r.goldschmidt@gmail.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi, On 16 November 2018 at 09:04, Simon Goldschmidt wrote: > > > Am Sa., 3. Nov. 2018, 08:56 hat Simon Goldschmidt > geschrieben: >> >> On 03.11.2018 07:08, Simon Glass wrote: >> > On 2 November 2018 at 14:28, Simon Goldschmidt >> > wrote: >> >> Add possibility to update the serial parity used. >> >> >> >> Signed-off-by: Simon Goldschmidt >> >> --- >> >> >> >> drivers/serial/ns16550.c | 43 >> >> ++++++++++++++++++++++++++++++++++++++-- >> >> 1 file changed, 41 insertions(+), 2 deletions(-) >> >> >> > Reviewed-by: Simon Glass >> > >> > Ideally we should call this from sandbox (or a test) somewhere. >> >> Hmm, I'm a bit lost there. I haven't really used the tests so far and >> grep'ing through test/ does not show any reference to ns16550 either >> (where I could easily add a test). >> >> Did you mean adding a test for this specific driver (ns16550) or for the >> call to 'setconfig' in general? (Because I thought Patrice had already >> done that.) > > > Simon, any input on this? Does your comment somehow hold back this from > being pushed? No, I added my review tag. It looks like serial_setconfig() is written without a struct udevice parameter. I think that should be fixed, since new functionality should use DM. Regards, Simon