From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4E04C433EF for ; Thu, 14 Oct 2021 15:17:46 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3593960F4A for ; Thu, 14 Oct 2021 15:17:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3593960F4A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6781B83844; Thu, 14 Oct 2021 17:15:15 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="SQl/Ndh9"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 633A6837E1; Thu, 14 Oct 2021 17:12:31 +0200 (CEST) Received: from mail-ot1-x32d.google.com (mail-ot1-x32d.google.com [IPv6:2607:f8b0:4864:20::32d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 80891837D5 for ; Thu, 14 Oct 2021 17:12:21 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-ot1-x32d.google.com with SMTP id l10-20020a056830154a00b00552b74d629aso3579435otp.5 for ; Thu, 14 Oct 2021 08:12:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=1UJUeRV346TfjEGv+510ZIZUd8iTYGihbtFvRzA8Vgk=; b=SQl/Ndh9ncD7Um5fLobdwhdC3ihmpagVe72VhID0d1GkaMpZQFp4n8foTBcBS4gAMa 3FpgEGcNA+Lv+uOC2hnrKqy8EV0GoFUmStoRqiT35Q50qK+Vbob3VXSIXidH4Y8K3ZXp jJjz32yS+7eQrWzgoCd0HVgIQJDLNavsY0olI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=1UJUeRV346TfjEGv+510ZIZUd8iTYGihbtFvRzA8Vgk=; b=0wRFLgMWYKgwFHmwQqlIbmjXr9ZajnCBIAlCbur5WVw3busB1hM4LFtRfwfPzTGLDD rku6mhO9V/XEurzCM3yg5pAIfIEoK0CKu+OOa2Y0scBcyLghKXGIwcFm256isiTDk0d/ srWghJvZbO//gmZcKTva7GmftLDPF5Qr6N0k1XTHImumWE8PZu8Q1Au2pZlRovnduD9g pVFbNaARe20QWD9VMPhYjYJ6cIDHzBYHdgsSIiZOV8kLwnloCYbAI/HkKcIn0FqwbXi3 UQTjs/ISeE1VLAg+jd1krevmB9o9dbE/imIN+DHLQhH7n6oPcu3fKF+j7VFRgltTaMoK pEdw== X-Gm-Message-State: AOAM533m/JgVzpubk59KMADZJIVbx3Ha3h1uRd2CsPBvW5MQMCdMpsdr XORdJjq98KSE2Egsvip3kU2sa+zKJf0LmcmolOo8Mw== X-Google-Smtp-Source: ABdhPJzrHMARvOZopWfJe+AN98JKnSSnkMD3HFgDxpN1Be41K7Sgbd8zT+TeXPczksmaaDBPa5O4A0KDjKAN2VqvrlY= X-Received: by 2002:a9d:17c5:: with SMTP id j63mr3140253otj.191.1634224339965; Thu, 14 Oct 2021 08:12:19 -0700 (PDT) MIME-Version: 1.0 References: <20211013154557.28479-1-kabel@kernel.org> <20211013154557.28479-12-kabel@kernel.org> In-Reply-To: <20211013154557.28479-12-kabel@kernel.org> From: Simon Glass Date: Thu, 14 Oct 2021 09:11:18 -0600 Message-ID: Subject: Re: [PATCH v2 11/13] env: Make return value of env_get_f() behave like sprintf() on success To: =?UTF-8?B?TWFyZWsgQmVow7pu?= Cc: Tom Rini , U-Boot Mailing List , =?UTF-8?B?TWFyZWsgQmVow7pu?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Wed, 13 Oct 2021 at 09:46, Marek Beh=C3=BAn wrote: > > From: Marek Beh=C3=BAn > > Currently the env_get_f() function's return value behaves weirdly: it > returns the number of bytes written into `buf`, but whether this is > excluding the terminating NULL-byte or including it depends on whether > there was enough space in `buf`. > > Change the function to always return the actual length of the value of > the environment variable (excluding the terminating NULL-byte) on > success. This makes it behave like sprintf(). > > All users of this function in U-Boot are compatible with this change. > > Signed-off-by: Marek Beh=C3=BAn > --- > cmd/nvedit.c | 8 +++++--- > include/env.h | 6 ++---- > 2 files changed, 7 insertions(+), 7 deletions(-) Reviewed-by: Simon Glass