All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [PATCH] regulator: fix: enable gpio when requested
Date: Mon, 27 Apr 2020 16:24:56 -0600	[thread overview]
Message-ID: <CAPnjgZ0UjnxXzmn3MjQLknF9GjB0yi8WQfGs57j6p=1GXFhkkA@mail.gmail.com> (raw)
In-Reply-To: <20200427090947.75951-1-kettenis@openbsd.org>

Hi Mark,

On Mon, 27 Apr 2020 at 03:09, Mark Kettenis <kettenis@openbsd.org> wrote:
>
> The fix in commit b7adcdd073c0 has the side-effect that the regulator
> will be disabled when requesting the relevant gpio in
> regulator_common_ofdata_to_platdata() and enabled in
> regulator_pre_probe() when the regulator was already enabled.
> This leads to a short interruption in the 3.3V power to the PCIe
> slot on the firefly-rk3399 which makes an ADATA SX8000NP NVMe SSD
> unhappy.
>
> Fix this by setting the GPIOD_IS_OUT_ACTIVE flag again when the
> 'regulator-boot-on' property is set, but check for this property
> explicitly instead of relying on the "boot_on" member of
> the uclass platdata.
>
> Signed-off-by: Mark Kettenis <kettenis@openbsd.org>
> ---
>  drivers/power/regulator/regulator-uclass.c | 3 ---
>  drivers/power/regulator/regulator_common.c | 2 ++
>  2 files changed, 2 insertions(+), 3 deletions(-)

Should this have a Fixed: tag?

Regards,
Simon

  parent reply	other threads:[~2020-04-27 22:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-27  9:09 [PATCH] regulator: fix: enable gpio when requested Mark Kettenis
2020-04-27 12:06 ` Patrice CHOTARD
2020-04-27 22:24 ` Simon Glass [this message]
2020-04-28  4:24 ` Lukasz Majewski
2020-04-28  9:23   ` Mark Kettenis
2020-04-28 18:26     ` Lukasz Majewski
2020-05-13  9:14       ` Mark Kettenis
2020-06-16 13:18 ` Tom Rini
2020-06-17 16:34   ` Mark Kettenis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPnjgZ0UjnxXzmn3MjQLknF9GjB0yi8WQfGs57j6p=1GXFhkkA@mail.gmail.com' \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.