From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Glass Date: Tue, 5 May 2020 21:42:34 -0600 Subject: [PATCH 1/6] rtc: add rtc_read8_array helper and ->read8_array method In-Reply-To: <20200504212032.3759-2-rasmus.villemoes@prevas.dk> References: <20200504212032.3759-1-rasmus.villemoes@prevas.dk> <20200504212032.3759-2-rasmus.villemoes@prevas.dk> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, 4 May 2020 at 15:20, Rasmus Villemoes wrote: > > Some users may want to read multiple consecutive 8-bit > registers. Instead of each caller having to implement the loop, > provide a rtc_read8_array() helper. Also, allow a driver to provide a > read8_array method, which can be more efficient than reading one > register at a time. > > Signed-off-by: Rasmus Villemoes > --- > drivers/rtc/rtc-uclass.c | 19 +++++++++++++++++++ > include/rtc.h | 24 ++++++++++++++++++++++++ > 2 files changed, 43 insertions(+) > > diff --git a/drivers/rtc/rtc-uclass.c b/drivers/rtc/rtc-uclass.c > index a0a238aedd..5070fb416d 100644 > --- a/drivers/rtc/rtc-uclass.c > +++ b/drivers/rtc/rtc-uclass.c > @@ -49,6 +49,25 @@ int rtc_read8(struct udevice *dev, unsigned int reg) > return ops->read8(dev, reg); > } > > +int rtc_read8_array(struct udevice *dev, unsigned int reg, > + u8 *buf, unsigned int len) How about just rtc_read() ? Reviewed-by: Simon Glass