All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: seanedmond@linux.microsoft.com
Cc: u-boot@lists.denx.de, dphadke@linux.microsoft.com,
	 ilias.apalodimas@linaro.org, trini@konsulko.com
Subject: Re: [PATCH v4 4/5] dm: core: Modify default for OFNODE_MULTI_TREE
Date: Sun, 12 Nov 2023 13:01:05 -0700	[thread overview]
Message-ID: <CAPnjgZ0Yr1c3bMzcaVe8KX4mhjby0FAfVV=zs29n0vd=gZVNbw@mail.gmail.com> (raw)
In-Reply-To: <CAPnjgZ0-o61kX7yanfi8TQKJj+sjBANUA13hjGSzxWN6EZHZZQ@mail.gmail.com>

Hi Sean,

On Fri, 3 Nov 2023 at 13:38, Simon Glass <sjg@chromium.org> wrote:
>
> On Fri, 3 Nov 2023 at 12:38, <seanedmond@linux.microsoft.com> wrote:
> >
> > From: Sean Edmond <seanedmond@microsoft.com>
> >
> > There is a preference to use the "ofnode" API for FDT fixups
> > moving forward.  The FDT fixup will usually be for the kernel FDT.  To
> > fixup the kernel FDT with the ofnode API, it's required to set the
> > OFNODE_MULTI_TREE option.
> >
> > To ensure existing users of kaslr fdt fixup are not impacted, Let's modify
> > the default value for OFNODE_MULTI_TREE to ensure it's always set if
> > !OF_LIVE.  This will cause a 1007 byte increase in the code size.
> >
> > Signed-off-by: Sean Edmond <seanedmond@microsoft.com>
> > ---
> >  drivers/core/Kconfig | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
>
> Reviewed-by: Simon Glass <sjg@chromium.org>

This actually disables the option for sandbox. You may as well enabled
it by default always, since if OF_LIVE is active we are already adding
a lot of code.

That explains the cedit error that Tom mentioned.

Regards,
Simon

  reply	other threads:[~2023-11-12 20:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-03 18:38 [PATCH v4 0/5] Populate kaslr seed with RNG seanedmond
2023-11-03 18:38 ` [PATCH v4 1/5] fdt: common API to populate kaslr seed seanedmond
2023-11-12 20:01   ` Simon Glass
2023-11-03 18:38 ` [PATCH v4 2/5] fdt: kaslr seed from RNG device seanedmond
2023-11-03 18:38 ` [PATCH v4 3/5] cmd: kaslrseed: Use common API to fixup FDT seanedmond
2023-11-12 20:01   ` Simon Glass
2023-11-03 18:38 ` [PATCH v4 4/5] dm: core: Modify default for OFNODE_MULTI_TREE seanedmond
2023-11-03 19:38   ` Simon Glass
2023-11-12 20:01     ` Simon Glass [this message]
2023-11-03 18:38 ` [PATCH v4 5/5] fdt: Fix compile error for !OFNODE_MULTI_TREE seanedmond
2023-11-03 19:38   ` Simon Glass
2023-11-10 17:48 ` [PATCH v4 0/5] Populate kaslr seed with RNG Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPnjgZ0Yr1c3bMzcaVe8KX4mhjby0FAfVV=zs29n0vd=gZVNbw@mail.gmail.com' \
    --to=sjg@chromium.org \
    --cc=dphadke@linux.microsoft.com \
    --cc=ilias.apalodimas@linaro.org \
    --cc=seanedmond@linux.microsoft.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.