All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [PATCH 2/2] test: Only enable bloblist test when supported
Date: Wed, 11 Nov 2020 07:31:59 -0700	[thread overview]
Message-ID: <CAPnjgZ0_OgYi2=yA1YkVA-9QSKf5z0LfCxCGr+Td+8CodUT0UQ@mail.gmail.com> (raw)
In-Reply-To: <1c153a79-d9c0-3772-2fc6-a63f21f82cba@gmx.de>

Hi Heinrich,

On Mon, 9 Nov 2020 at 00:42, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>
> On 09.11.20 05:08, Simon Glass wrote:
> > This test cannot work unless CONFIG_BLOBLIST is enabled. Update it to add
> > that condition.
> >
> > Reported-by: Kever Yang <kever.yang@rock-chips.com>
> > Signed-off-by: Simon Glass <sjg@chromium.org>
> > ---
> >
> >  test/Makefile | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/test/Makefile b/test/Makefile
> > index 1c930b31485..cdbfa61cda3 100644
> > --- a/test/Makefile
> > +++ b/test/Makefile
> > @@ -2,7 +2,9 @@
> >  #
> >  # (C) Copyright 2012 The Chromium Authors
> >
> > +ifneq ($(CONFIG_$(SPL_)BLOBLIST),)
> >  obj-$(CONFIG_$(SPL_)CMDLINE) += bloblist.o
> > +endif
> >  obj-$(CONFIG_$(SPL_)CMDLINE) += cmd/
> >  obj-$(CONFIG_$(SPL_)CMDLINE) += cmd_ut.o
> >  obj-$(CONFIG_$(SPL_)CMDLINE) += command_ut.o
> >
>
> This patch conflicts with my patch
>
> [1/1] test: test/bloblist.c depends on asm/state.h
> https://patchwork.ozlabs.org/project/uboot/patch/20201031073806.30736-1-xypron.glpk at gmx.de/
>
> It seems that my patch is obsoleted by the first patch of Kever's series:
>
> test: Avoid assuming sandbox board for bloblist test
> https://patchwork.ozlabs.org/project/uboot/patch/20201108210834.1.I08cec35c8482583834811d48894f358277c662aa at changeid/

I believe your patch was already applied, so there should not be a
patch conflict.

Yes there was a request to be able to run the test on boards other
than sandbox. I think we should try to do that if possible.

Regards,
Simon

      reply	other threads:[~2020-11-11 14:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-09  4:08 [PATCH 1/2] test: Avoid assuming sandbox board for bloblist test Simon Glass
2020-11-09  4:08 ` [PATCH 2/2] test: Only enable bloblist test when supported Simon Glass
2020-11-09  7:42   ` Heinrich Schuchardt
2020-11-11 14:31     ` Simon Glass [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPnjgZ0_OgYi2=yA1YkVA-9QSKf5z0LfCxCGr+Td+8CodUT0UQ@mail.gmail.com' \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.