From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10C01C433EF for ; Wed, 8 Sep 2021 12:07:08 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6B0936109F for ; Wed, 8 Sep 2021 12:07:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6B0936109F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6806481E1C; Wed, 8 Sep 2021 14:07:05 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="Ip0ng726"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7241A82C0C; Wed, 8 Sep 2021 14:07:03 +0200 (CEST) Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5D63881E14 for ; Wed, 8 Sep 2021 14:07:00 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-wm1-x334.google.com with SMTP id n14-20020a05600c3b8e00b002f8bd2f8ab6so1391673wms.5 for ; Wed, 08 Sep 2021 05:07:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kX0QhdTkrSwN5V5CirqknJpqlMo42MokmprtsRtMiN4=; b=Ip0ng726XYr8bHKuoAhr/JBSOqjaH8sCq//TMacflPGlq2YEQlOUimnVFYEfwoTjgf 9Mw5UKNqBre8BTTVOyFh78T1pqhd13bddS4U7IBDQSp3B4OTYcS+VPYsl4OMrXGRJUi/ f3tDNZCp/Fm7JnFIwp6QT2jGy/0TrG0T5X0yk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kX0QhdTkrSwN5V5CirqknJpqlMo42MokmprtsRtMiN4=; b=Lor3Eo9d9uVvgAcD2c+5kmXoyTdHOCHNhO1ujTCN+0RrwMY8dwILkN20K/kg16ht8O i4haRwUR4Tj7liddz2G5p7IHbGcezF3vlHekpCDVx8XKxqR7z0UUl1DF9JZ67u154zE7 uC669+CehugM6ROWCmBCmDnGHJrWmgHUEt+RuH2kkNWwvrz3opnOtt0BV5j23HzMWx6y X3v8fiuiISmUQiR5YfaGS7Raak4Py1S/EXASitVjaS2eWVWOaLIzzddaOD8T/nbqPD9L 5XIlOmgMPedn0J5nyv8DskKXYEJ3p7Pc3ssY6s4OGqeAvNO1bS7db5Ea9AYT4dKKgCkj 9EUQ== X-Gm-Message-State: AOAM531eWlxvW8tET5AlPF6u4EE1R5mCI01XUYvA6qKc6wjvnKprVrsB Y39Vs9E/BZGt7YzGKhTykkkNrMarL+hIrwe1LoceGQ== X-Google-Smtp-Source: ABdhPJxfEn3pvZF1mPJ/VEM4TDuRvzzONSCIoYpVBTNd2MQbZHDMSqKXx1rZU3SzeRt/gpkHeihVLvUhiYbq2uvLABw= X-Received: by 2002:a7b:cb04:: with SMTP id u4mr3282232wmj.18.1631102819534; Wed, 08 Sep 2021 05:06:59 -0700 (PDT) MIME-Version: 1.0 References: <20210907070108.8200-1-xypron.glpk@gmx.de> <20210907112517.GB49004@laputa> In-Reply-To: From: Simon Glass Date: Wed, 8 Sep 2021 06:06:48 -0600 Message-ID: Subject: Re: [PATCH 1/1] efi_loader: require CONFIG_BLK To: Heinrich Schuchardt Cc: AKASHI Takahiro , U-Boot Mailing List , Alexander Graf Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Heinrich, On Tue, 7 Sept 2021 at 17:35, Heinrich Schuchardt wrote: > > On 9/7/21 1:25 PM, AKASHI Takahiro wrote: > > On Tue, Sep 07, 2021 at 09:01:08AM +0200, Heinrich Schuchardt wrote: > >> The move to driver model should by now be completed. To be able to remove > >> pre-driver model code from our block IO code require CONFIG_BLK=y for UEFI > >> support. > > > > If so, we can safely remove !CONFIG_BLK-related code > > from efi_disk.c and efi_device_path.c. > > Yes, that was my intent. As we want to improve the integration with the > driver model we should get rid of the outdated non-BLK code. Let's merge > that into the next branch. I have a patch locally for that. I hope to send the series out soon. Regards, Simon > > Best regards > > Heinrich > > > > > -Takahiro Akashi > > > > > >> Signed-off-by: Heinrich Schuchardt > >> --- > >> lib/efi_loader/Kconfig | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig > >> index dacc3b5881..692cf5ced0 100644 > >> --- a/lib/efi_loader/Kconfig > >> +++ b/lib/efi_loader/Kconfig > >> @@ -10,6 +10,7 @@ config EFI_LOADER > >> depends on !EFI_STUB || !X86_64 || EFI_STUB_64BIT > >> # We need EFI_STUB_32BIT to be set on x86_32 with EFI_STUB > >> depends on !EFI_STUB || !X86 || X86_64 || EFI_STUB_32BIT > >> + depends on BLK > >> default y if !ARM || SYS_CPU = armv7 || SYS_CPU = armv8 > >> select LIB_UUID > >> select PARTITION_UUIDS > >> -- > >> 2.30.2 > >> >