From mboxrd@z Thu Jan  1 00:00:00 1970
From: Simon Glass <sjg@chromium.org>
Date: Sat, 24 Apr 2021 16:56:19 +1200
Subject: [PATCH 12/17] x86: coreboot: Use vendor in the Kconfig
In-Reply-To: <CAEUhbmVqt-E5PinJHQ6QgD6Xd6wwRae7wW1OELzeQGHowyVG4A@mail.gmail.com>
References: <20210407043228.2268429-1-sjg@chromium.org>
 <20210407163159.12.Ic028f6df43c9740024371590bbe8ea1be27ec45f@changeid>
 <CAEUhbmVqt-E5PinJHQ6QgD6Xd6wwRae7wW1OELzeQGHowyVG4A@mail.gmail.com>
Message-ID: <CAPnjgZ0_s6wWBpMk0jL+47LMYuTYsfAROkvPtJbViF9Xt8VjKA@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Bin,

On Thu, 8 Apr 2021 at 14:59, Bin Meng <bmeng.cn@gmail.com> wrote:
>
> Hi Simon,
>
> On Wed, Apr 7, 2021 at 12:33 PM Simon Glass <sjg@chromium.org> wrote:
> >
> > Use VENDOR_COREBOOT instead of TARGET_COREBOOT so we can have multiple
> > coreboot boards, sharing options. Only SYS_CONFIG_NAME needs to be
> > defined TARGET_COREBOOT.
> >
>
> I am not sure what use case this is? This change makes no difference
> when U-Boot is built as a coreboot payload.

This is because I want to add another coreboot board, called
'chromeos_coreboot'. So in that case it will have VENDOR_COREBOOT
enabled, but not TARGET_COREBOOT.

>
> > Signed-off-by: Simon Glass <sjg@chromium.org>
> > ---
> >
> >  arch/x86/cpu/coreboot/Kconfig   |  2 +-
> >  board/coreboot/coreboot/Kconfig | 12 ++++++++----
> >  2 files changed, 9 insertions(+), 5 deletions(-)
> >
>
> Regards,
> Bin

Depending on a particular TARGET Kconfig is not a good idea, IMO.

Regards,
Simon