From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 60898C433F5 for ; Thu, 29 Sep 2022 10:01:48 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 236ED84D68; Thu, 29 Sep 2022 12:01:20 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="k/Wu7CBL"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id F096884CBC; Thu, 29 Sep 2022 12:00:47 +0200 (CEST) Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8623B84B2B for ; Thu, 29 Sep 2022 12:00:42 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-wr1-x431.google.com with SMTP id x18so1348277wrm.7 for ; Thu, 29 Sep 2022 03:00:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=b/pdt3UxTdmG+ByRVsAwvJXwR5xe/0F8WDX8/bNy+TI=; b=k/Wu7CBL1qQLoTytW4tmjGt9fuOnby+bbJTShyENX9dWillpa9ciQp4o2A3yKKiRxG WbkQ8wE1UzxH+eEyJHVqfIXm6GyMxHAyO9epZ/yrsxtARpcArRUTwJz6CyzVLMufVFkh 3VDEpRK6BI8KCdmxiLTZzDlGbBbihNW9rN3qU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=b/pdt3UxTdmG+ByRVsAwvJXwR5xe/0F8WDX8/bNy+TI=; b=bJ1du/EdK7pE8nIjxOt7ZpAyMfAZ+5o5lDmS784sO84cdYqoOFgjikwfU3oEaSyird eQLiPjqOBWJi5UnH9R9vn6mIgZy2sZYqJ73SmG5qMMRG/jNMdxB9vtVrXtEVRyfXltlb 0GP+rQRLLqWSvPmJd4HdwNVEEnofSfVCUxYQvkyrLdzB/al30X8WG+F1oYeSflgjWypK +44rOkQs0Y8afKLjgnNBKfe5ygcMm/k9seZd4iCppRfjmfojQoNV6JJ8FxQQYPdiNb4Q d50HQ1PlH0S8xXHy+j4rPt2LXSo+UmTIxWkcsbPkM4eLAOHkohuxd+FvHvtLxdfqcJow bq4g== X-Gm-Message-State: ACrzQf15d187Q2ZVD/g140uZeGdsHvaKlBUvVxOgJh3wjxez9pyW3Bp8 cgbEJRHKe+Rn0Gw4V5jTKmMhO0yoi7pc2+M4B32g8Q== X-Google-Smtp-Source: AMsMyM5Bno4+v0NdVyx/EY94rbfRV0fxQW/4RyP5yabnidPxLJBD1MD790W7QpJU06i1KD+37DupGhnig6QAkP4XbCU= X-Received: by 2002:a05:6000:18a1:b0:22a:f4c2:c9e6 with SMTP id b1-20020a05600018a100b0022af4c2c9e6mr1666804wri.71.1664445641874; Thu, 29 Sep 2022 03:00:41 -0700 (PDT) MIME-Version: 1.0 References: <420f314d458db9d40e104773254a61dab954442e.1664314043.git.msuchanek@suse.de> In-Reply-To: <420f314d458db9d40e104773254a61dab954442e.1664314043.git.msuchanek@suse.de> From: Simon Glass Date: Thu, 29 Sep 2022 04:00:28 -0600 Message-ID: Subject: Re: [PATCH v5 01/15] dm: core: Fix uclass_probe_all to really probe all devices To: Michal Suchanek Cc: U-Boot Mailing List , Sean Anderson , Stefan Roese , Vabhav Sharma Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Tue, 27 Sept 2022 at 15:38, Michal Suchanek wrote: > > uclass_probe_all uses uclass_first_device/uclass_next_device assigning > the return value. > > The interface for getting meaningful error is > uclass_first_device_check/uclass_next_device_check, use it. > > Also do not stop iteration when an error is encountered. Probing all > devices includes those that happen to be after a failing device in the > uclass order. > > Fixes: a59153dfeb ("dm: core: add function uclass_probe_all() to probe all devices") > Signed-off-by: Michal Suchanek > --- > drivers/core/uclass.c | 12 +++++------- > 1 file changed, 5 insertions(+), 7 deletions(-) > Reviewed-by: Simon Glass but this could use a test e.g. in test/dm/core.c