From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EA788C4332F for ; Fri, 25 Nov 2022 04:02:20 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 983E785658; Fri, 25 Nov 2022 05:02:11 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="jyaAJt4g"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 41F1585254; Fri, 25 Nov 2022 05:02:09 +0100 (CET) Received: from mail-io1-xd30.google.com (mail-io1-xd30.google.com [IPv6:2607:f8b0:4864:20::d30]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 081B785658 for ; Fri, 25 Nov 2022 05:02:05 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-io1-xd30.google.com with SMTP id e189so2336429iof.1 for ; Thu, 24 Nov 2022 20:02:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=O5G9XpNzn2AXVuE5eK0+wTFZIGias8WhjlxJJccgx1U=; b=jyaAJt4g7E1RMCrJqa2tCRzgmGcK2ThdMu89UQtjupMoa1ShqhUl23zZIyAMYDcI/A NJS8dqqLvqDrMSp9ObtLlnQ83bV5Nm1pdohJcTbxwCCBDWnbmTS3FM6hMUMN8mb/Gl98 EjzOyf+qXWFchu+GPNjQrZ7icAvvkzsy98cNs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=O5G9XpNzn2AXVuE5eK0+wTFZIGias8WhjlxJJccgx1U=; b=tP43zNL7low9hIIdAy7akzqbGVL18tDZSXr6wY0hGzC1GUE2cd0ubvw53PqTXl3T0c D5K1Dziml12PJJY3Sahi8H5UHY5Do0bmDZJgayBekSDEFIeM0+BSD2Ejw6qmlc55Oas7 2QmlncvHYEFEWf1g2vWC748mDSc8yMyF/mDvU+oo/8y9L+jU3UrxuGwl0GmtMb48ylyq kor7o8r7ytMYZyaLxRqWYuke31Q5KkqzPDlmsizvIHFoNYgpqU8RWIuaWN14ansVocDm w0sWGXZemKPPhWzBiJLGgrtrooBRLXnN2SGrBVBkDJYTOmTxLjtG7pLezw/gluWeya9U fQiw== X-Gm-Message-State: ANoB5pnSuFUxp4eW2CgXqFiwGQzkkNyje+NZmgH9zVP2Hw/qriqT89hA xncaNavrsmlsxV4nPrJGzhvRsSpF+Nsr0qjjVnMYgzKycpr7Jg== X-Google-Smtp-Source: AA0mqf4Hy49KcuQi7mX7I2B5eQZQHlLGhOZeE/JUG/hEeoSra5Hcls+aZUzoA82wHU11TUNbFRNo4FwfR84EEneHw7k= X-Received: by 2002:a5d:860b:0:b0:6da:46b4:85f6 with SMTP id f11-20020a5d860b000000b006da46b485f6mr7317521iol.147.1669348923245; Thu, 24 Nov 2022 20:02:03 -0800 (PST) MIME-Version: 1.0 References: <20221123105949.26475-1-ilin.mikhail.ol@gmail.com> In-Reply-To: <20221123105949.26475-1-ilin.mikhail.ol@gmail.com> From: Simon Glass Date: Thu, 24 Nov 2022 21:01:48 -0700 Message-ID: Subject: Re: [PATCH] tools: imx8image: Fix handle leak To: Mikhail Ilin Cc: Peng Fan , u-boot@lists.denx.de Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Wed, 23 Nov 2022 at 04:00, Mikhail Ilin wrote: > > The handle "fd" was created in imx8image.c:249 by calling the "fopen" > function and is lost in imx8image.c:282. > Should close the 'fd' file descriptor before exiting the > parse_cfg_file(image_t *param_stack, char *name) function. > > Fixes: a2b96ece5be1 ("tools: add i.MX8/8X image support") > Signed-off-by: Mikhail Ilin > --- > tools/imx8image.c | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Simon Glass