From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 56386CCA47F for ; Tue, 28 Jun 2022 13:44:05 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4E4E38451A; Tue, 28 Jun 2022 15:39:44 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="RyAYFy0K"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7719684519; Tue, 28 Jun 2022 15:39:41 +0200 (CEST) Received: from mail-vk1-xa33.google.com (mail-vk1-xa33.google.com [IPv6:2607:f8b0:4864:20::a33]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5C630844D5 for ; Tue, 28 Jun 2022 15:38:50 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-vk1-xa33.google.com with SMTP id 15so5943511vko.13 for ; Tue, 28 Jun 2022 06:38:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:sender:from:in-reply-to:references:date:message-id :subject:to:cc; bh=rKz8pCqRyOYG0l01S3eTYyhJIoQg6db81xNQIr7MQVk=; b=RyAYFy0Khm28lz3baCh2B3jruNHtTu+rX8nV3rda39bf58WCc59JSNFiXf9Hofx6kW sjanD9mXqdaU3P/ZYzQZeJAsgA+QyOExN3L4oRD6vxVFbKT5vr/CDu0ORMNG7ZjvatM5 d8lm5E1h8PLB5UbF1LFsKmpP7MDrqSzSpdr/c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:sender:from:in-reply-to:references :date:message-id:subject:to:cc; bh=rKz8pCqRyOYG0l01S3eTYyhJIoQg6db81xNQIr7MQVk=; b=HhZrbmO19poIvfwHZbGCIzA0u6wlIJ3qmS1SivmS+UpR5DzKoLXwqAVDZKkTsDXGF8 xxm33urf+EuztyExCz5bWTLpjy795db9wDl1wg+zzJ8A2XRtbZEbeIHwNl8d1fs8hPkk 5gbvkAu3SQFqX/WwdD29cjlSeyUzfGN5GvwXNHxNYKIih3++MRiMF/9y12CYByiBvUdk gtTdho9AErBwIJ6CIYadQMrUiko/CnsLsdMcHeBMvFwDueE2Kv8HhMmW2yLc6+H5bbWE TEIgixgPSy3PChgDKJljhEou8nOK95STB34w9l7iUBX0PiqHcetLXs9p+4KyjApSlbhE GAsg== X-Gm-Message-State: AJIora9oxcRL/DexxphTh43T4wq7wI1GBGgMjZ87WjUSP41DJTnceUiZ lJAEgR6k5jS1RrtgcAfPrY/yUl7BzHbnIVckTidUzxVjozc= X-Google-Smtp-Source: AGRyM1vTTcwLs2MzfHNYwiWoLSKqkvRy5uDyEiLn9WDiJui8427qRWB5jyN7/+bWzXeTTI93hKagkLmJh0dTB/AF7TA= X-Received: by 2002:ac5:c391:0:b0:36b:f530:4c1a with SMTP id s17-20020ac5c391000000b0036bf5304c1amr2115761vkk.8.1656423495433; Tue, 28 Jun 2022 06:38:15 -0700 (PDT) Received: from 480794996271 named unknown by gmailapi.google.com with HTTPREST; Tue, 28 Jun 2022 09:38:14 -0400 MIME-Version: 1.0 From: Simon Glass In-Reply-To: References: <20220402170609.17790-1-alpernebiyasak@gmail.com> <20220402170609.17790-3-alpernebiyasak@gmail.com> Date: Tue, 28 Jun 2022 09:38:14 -0400 X-Google-Sender-Auth: P-vfYm7GMKgyfYFxz8zt1eQ2X3g Message-ID: Subject: Re: [PATCH 2/5] patman: test_util: Handle nonexistent tests while loading tests To: Simon Glass Cc: U-Boot Mailing List , Walter Lozano , Alper Nebi Yasak Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Sat, 2 Apr 2022 at 11:06, Alper Nebi Yasak wrote: > > It's possible to request a specific test to run when trying to run a > python tool's tests. If we request a nonexistent test, the unittest > loaders generate a fake test that reports this as an error. However, we > get these fake tests even when the test exists, because test_util can > load tests from multiple places one by one and the test we want only > exists in one. > > The test_util helpers currently remove these fake tests when printing > test results, but that's more of a workaround than a proper solution. > Instead, don't even try to load the missing tests. > > Signed-off-by: Alper Nebi Yasak > --- > > tools/patman/test_util.py | 21 +++++---------------- > 1 file changed, 5 insertions(+), 16 deletions(-) Reviewed-by: Simon Glass Applied to u-boot-dm, thanks!