From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7FD11C25B0E for ; Tue, 16 Aug 2022 20:44:20 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8EC178492E; Tue, 16 Aug 2022 22:44:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="SpCTDyGr"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 44AF6848F0; Tue, 16 Aug 2022 22:44:16 +0200 (CEST) Received: from mail-oi1-x22c.google.com (mail-oi1-x22c.google.com [IPv6:2607:f8b0:4864:20::22c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D4B4F84939 for ; Tue, 16 Aug 2022 22:44:13 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-oi1-x22c.google.com with SMTP id o184so13305385oif.13 for ; Tue, 16 Aug 2022 13:44:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=RztYnnfMl9ZUjaCnhwN3OgRkzesyb/4ia72wgJfcNFQ=; b=SpCTDyGrYQDegctLRw7QGogrCZxCT2ZnJwlBtJc8fBFtp09RnlBpOysW6RlnIQh7Dh vl3mKpoOjNflJiF9uO/XMLcwouHVATX7xt6vlaIqnCbEtAXMuy9QGqFTMnAXtxMoHljW 61RkGiQzP29j2IEaGHL2pkPvbekX+6K9Orooc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=RztYnnfMl9ZUjaCnhwN3OgRkzesyb/4ia72wgJfcNFQ=; b=oOs1cCHxAELA5pOH1pndPsiob7ABw+DtDOmwx7rnBzUMltdNTeUrGoKcZyGDzTKn0X 6TIRNSsbiLgKrd9F3Cmldcz1GjoimdeyPlDRPB+Irhr8KakbcTK+UHtOkSEYWwfBiTtL BfUTP4c4GdOEOSA9huPLLlW2j5R7BGFWKtcxhRovLVZFfOBXF9H1xKxjH3NeJtaPyGoU OtDnP7HKZHfINgWxXTTvYgDNEPxvvi8xwG7BDyb80BvLCt2/NCRNPPffAaKBg9Ggq8U4 rzhG6pRvcJ93Eo6BoptRmqUcXr4ZYHuvbmuDhVUyTfX2587MR8zmihuEQaZE8QDegk0A oc/g== X-Gm-Message-State: ACgBeo0F5IpiNVCya5EmsPhOJKrADswenwM9zSCJPEwwX/Sxi4kS68kv kEIGqeCXqWNwCeY+rEN8C3zyfyAMN+vwa7N9CWVqDw== X-Google-Smtp-Source: AA6agR7iNIXI8P1XqdjwdtMthpM4EaK5zW999EUvIjTgR6Cl0F2PCRzwMlFDYSdLQQD/0nxwHDlcTuCWEg+VsoFjtKM= X-Received: by 2002:aca:bdc6:0:b0:344:a8a9:be49 with SMTP id n189-20020acabdc6000000b00344a8a9be49mr172417oif.64.1660682652139; Tue, 16 Aug 2022 13:44:12 -0700 (PDT) MIME-Version: 1.0 References: <20220816151607.1569660-1-sean.anderson@seco.com> <20220816151607.1569660-7-sean.anderson@seco.com> In-Reply-To: <20220816151607.1569660-7-sean.anderson@seco.com> From: Simon Glass Date: Tue, 16 Aug 2022 14:42:59 -0600 Message-ID: Subject: Re: [RESEND PATCH v2 6/6] net: fm: Add support for FIT firmware To: Sean Anderson Cc: Peng Fan , U-Boot Mailing List , York Sun , Ramon Fried , Joe Hershberger , Priyanka Jain Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Tue, 16 Aug 2022 at 09:16, Sean Anderson wrote: > > Fman microcode is executable code (AFAICT) loaded into a > coprocessor. As such, if verified boot is enabled, it must be verified > like other executable code. However, this is not currently done. > > This commit adds verified boot functionality by encapsulating the > microcode in a FIT, which can then be signed/verified as normal. By > default we allow fallback to unencapsulated firmware, but if > CONFIG_FIT_SIGNATURE is enabled, then we make it mandatory. Because > existing Layerscape do not use this config (instead enabling > CONFIG_CHAIN_OF_TRUST), this should not break any existing boards. > > An example (mildly-abbreviated) its is provided below: > > / { > #address-cells = <1>; > > images { > firmware { > data = /incbin/(/path/to/firmware); > type = "firmware"; > arch = "arm64"; > compression = "none"; > signature { > algo = "sha256,rsa2048"; > key-name-hint = "your key name"; > }; > }; > }; > > configurations { > default = "conf"; > conf { > description = "Load FMAN microcode"; > fman = "firmware"; > }; > }; > }; > > Signed-off-by: Sean Anderson > --- > > (no changes since v1) > > drivers/net/fm/fm.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) Reviewed-by: Simon Glass