From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E89EC432BE for ; Mon, 2 Aug 2021 14:45:48 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C58DF60E97 for ; Mon, 2 Aug 2021 14:45:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C58DF60E97 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C3D1B83404; Mon, 2 Aug 2021 16:45:13 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="KWCeQJo8"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 807FA833F7; Mon, 2 Aug 2021 16:45:11 +0200 (CEST) Received: from mail-oi1-x235.google.com (mail-oi1-x235.google.com [IPv6:2607:f8b0:4864:20::235]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 54E2383403 for ; Mon, 2 Aug 2021 16:45:01 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-oi1-x235.google.com with SMTP id z26so24343957oih.10 for ; Mon, 02 Aug 2021 07:45:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eGMpFH19CzRtZsxr58U++ygSexiqKDyLxN2xAsivplA=; b=KWCeQJo88pH/dTJRjy/T5OuzbTa7l2XW1MNI83VfxApHPs8Buo4VKR96jz2UzuNiUw elpRqqqzjHNjhNzZCCdVkpPOPSqZxZHMGVr6hGt/PPA7ai9709RAzFzzJ353yXQNmi9Q CZOsukTjjEQB1FJsGQS1mENV5DAaxfPF1Xng8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eGMpFH19CzRtZsxr58U++ygSexiqKDyLxN2xAsivplA=; b=BJuHwSKv2JobSmzFwP8Mc/GUpZ7vWrs3pj0uxslDkq+WpSVfnbZ00uM72ObdYREO0R GSd31LK8xJSKxPxGjNXiR+4QbXFvTKSir30TcfvZNWpOPNhod8MhJU83LB2ixVObhTs3 dfkV/z7A5/7RL24uCKyI3a5tY+arPuGGLDj0BLPdRtDPBOPUaDghX2xAdlpWHRmVuABs rWeLAEa+X0oFwD65omjd477dMtt0ItjjQBpk5avekO3HnY6bOUk8vgLP7CEmNjGFXQSl KgDFp/ZHNdi8iVwta4/QO0LpvEq/CvGu9YykKhzNnZzj9I18mCrx/91Ct2J/cguxysZI 81fw== X-Gm-Message-State: AOAM5304C+aWWvUvvbLh4ggnfx3/phmvatqJ8Ygn20gdOgOkeL58p94o h+r5e7ePvYs+nIoW9PeUNIbRsBy8AU9QMf9M0ypSjg== X-Google-Smtp-Source: ABdhPJzjOUcnGb+gnznewrIW6FHY8fAeKNkuysNT9McaZbncL9ZIYiiWdWeS6wM0+rfa7a/aVENn7XBwP3pdfjXPkpM= X-Received: by 2002:aca:1101:: with SMTP id 1mr10643627oir.53.1627915499745; Mon, 02 Aug 2021 07:44:59 -0700 (PDT) MIME-Version: 1.0 References: <20210802070516.758415-1-bmeng.cn@gmail.com> In-Reply-To: <20210802070516.758415-1-bmeng.cn@gmail.com> From: Simon Glass Date: Mon, 2 Aug 2021 08:44:48 -0600 Message-ID: Subject: Re: [PATCH v2 1/2] x86: queensbay: Return directly if IGD / SDVO were already disabled To: Bin Meng Cc: U-Boot Mailing List Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Mon, 2 Aug 2021 at 01:05, Bin Meng wrote: > > Initialize 'igd' and 'sdvo' to NULL so that we just need to test > them against NULL later, to be compatible with that case that IGD > and SDVO devices were already in disabled state. > > Signed-off-by: Bin Meng > > --- > > Changes in v2: > - Reword the commit message and add a comment in the codes > > arch/x86/cpu/queensbay/tnc.c | 20 +++++++++----------- > 1 file changed, 9 insertions(+), 11 deletions(-) Reviewed-by: Simon Glass