From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Glass Date: Wed, 16 Sep 2020 21:44:42 -0600 Subject: [PATCH 2/4] net: mdio: Supply appropriate devices for dev_dgb calls In-Reply-To: <9fb560bc-9901-ec5c-737f-b5ae8822fa9a@gmail.com> References: <20200913002821.404022-1-seanga2@gmail.com> <20200913002821.404022-3-seanga2@gmail.com> <9fb560bc-9901-ec5c-737f-b5ae8822fa9a@gmail.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Sean, On Wed, 16 Sep 2020 at 19:40, Sean Anderson wrote: > > > On 9/16/20 9:09 PM, Simon Glass wrote: > > On Sat, 12 Sep 2020 at 18:28, Sean Anderson wrote: > >> > >> The name of the device we are working on is `ethdev` and not just `dev`. > >> > >> Signed-off-by: Sean Anderson > >> --- > >> > >> net/mdio-uclass.c | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > > > > Reviewed-by: Simon Glass > > > > BTW I really like using 'dev' for the struct udevice if there is only > > one, and other names for other things (e.g. edev for Ethernet, udev > > for USB). > > > > Yeah, I think it is only really necessary when disambiguating between > several different devices. However, I am trying to make these patches as > minimal as possible, so I would like to keep the variable names the same > where possible. Yes definitely better the way you have the patches now.