All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [PATCH] remove struct uclass_driver::ops
Date: Wed, 19 May 2021 10:36:34 -0600	[thread overview]
Message-ID: <CAPnjgZ0dfR-CV8+Dm+Cmbx5X41M1q5B-QiWZ9tMozkMnmJsW4A@mail.gmail.com> (raw)
In-Reply-To: <20210519160811.183102-1-rasmus.villemoes@prevas.dk>

On Wed, 19 May 2021 at 10:08, Rasmus Villemoes
<rasmus.villemoes@prevas.dk> wrote:
>
> Each _device_ belonging to a given uclass of course has its own ->ops,
> of a type determined by and known to the uclass.
>
> However, no instance of a uclass_driver seems to populate ->ops, and
> the only reference to it in code is this relocation.
>
> Moreover, it's not really clear what could sensibly be assigned; it
> would have to be some "struct uclass_ops *" providing a set of methods
> for the core to call on that particular uclass, but should the need
> for that ever arise, it would be better to have a member of that
> particular type instead of void*.
>
> Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
> ---
>  drivers/core/root.c | 3 ---
>  include/dm/uclass.h | 3 ---
>  2 files changed, 6 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

  reply	other threads:[~2021-05-19 16:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-19 16:08 [PATCH] remove struct uclass_driver::ops Rasmus Villemoes
2021-05-19 16:36 ` Simon Glass [this message]
2021-07-04 20:15 ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPnjgZ0dfR-CV8+Dm+Cmbx5X41M1q5B-QiWZ9tMozkMnmJsW4A@mail.gmail.com \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.