From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Glass Date: Sat, 24 Apr 2021 16:56:18 +1200 Subject: [PATCH 04/17] spi: ich: Don't require the PCH In-Reply-To: References: <20210407043228.2268429-1-sjg@chromium.org> <20210407043228.2268429-4-sjg@chromium.org> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Bin, On Thu, 8 Apr 2021 at 14:28, Bin Meng wrote: > > On Wed, Apr 7, 2021 at 12:34 PM Simon Glass wrote: > > > > When booting from coreboot we may not have a PCH driver available. The > > SPI driver can operate without the PCH but currently complains in this > > case. Update it to continue to work normally. The only missing feature > > is memory-mapping of SPI-flash contents, which is not essential. > > > > Signed-off-by: Simon Glass > > --- > > > > drivers/spi/ich.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > Reviewed-by: Bin Meng > > But I feel this driver is slightly becoming unmaintainable as there > are many combinations we need to consider ... Yes it is a bit of a pain. The main one is that in some cases the SPI bus appears on PCI and in others it is part of the PCH or LPC. This is a hardware thing though, so I'm not sure what we can do about it. Perhaps split up the driver? Regards, Simon