From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 15/21] Refactor the bootm command to reduce code duplication
Date: Thu, 27 Jun 2013 23:58:12 -0700 [thread overview]
Message-ID: <CAPnjgZ0fS9J1T2AoH-_bXGuzcuFTjopXBwoMCF9qWc5FLcm=Cg@mail.gmail.com> (raw)
In-Reply-To: <51CD0D24.70600@denx.de>
Hi Stefan,
On Thu, Jun 27, 2013 at 9:12 PM, Stefan Roese <sr@denx.de> wrote:
> Hi Simon,
>
> On 06/28/2013 04:14 AM, Simon Glass wrote:
> > I can create something with or without compression and I cannot see the
> > failure. Tom is seeing it though. I will see if I can get another board
> > to try. If you have any ideas please let me know.
>
> Sorry, but I don't have any ideas. I also checked the parameters of the
> gunzip call. And they were identical in the working (before this patch)
> and non-working version (with this patch). gunzip() just didn't return.
>
> One idea: It might have something to do with the interrupt disabling, as
> powerpc compresses to 0. And thats the location of the interrupt vectors
> (timer?). Just an idea. Do you remember shuffling the
> disable_interrupts() call around?
>
Hmmm yes I did shuffle them around, figuring that the interrupts needed to
be disabled before booting the OS but not before loading it. It seems like
I made a bad assumption here.
I have been through the code multiple times and I cannot see a difference
in operation. Also it does work correctly on the ARM platforms I have
tried. It is broken on Tom's ARM platform, but perhaps that could be an
interrupt issue also.
I am going to post a patch to restore the interrupt code to where it was,
hoping that this shows some difference for your error. I will also post a
couple of revert patches for those who are blocked on this. We will have to
apply reverts fairly soon if the solution doesn't present itself.
> I'll check myself in a few hours.
>
OK please let me know if you find anything else. Thanks for your help.
Refactoring code is a tricky business...I much prefer the new bootm code,
if it can work on all platforms.
Regards,
Simon
next prev parent reply other threads:[~2013-06-28 6:58 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-11 18:14 [U-Boot] [PATCH v2 0/21] Add tracing functionality to U-Boot Simon Glass
2013-06-11 18:14 ` [U-Boot] [PATCH v2 01/21] pci: Convert extern inline functions to static inline Simon Glass
2013-06-11 18:14 ` [U-Boot] [PATCH v2 02/21] x86: Correct missing local variable in bootm Simon Glass
2013-06-11 18:14 ` [U-Boot] [PATCH v2 03/21] Fix missing return in do_mem_loop() Simon Glass
2013-06-11 18:14 ` [U-Boot] [PATCH v2 04/21] Show stdout on error in fit-test Simon Glass
2013-06-11 18:14 ` [U-Boot] [PATCH v2 05/21] bootstage: Correct printf types Simon Glass
2013-06-11 18:14 ` [U-Boot] [PATCH v2 06/21] Add function to print a number with grouped digits Simon Glass
2013-06-11 18:14 ` [U-Boot] [PATCH v2 07/21] Add trace library Simon Glass
2013-06-11 18:14 ` [U-Boot] [PATCH v2 08/21] Add a trace command Simon Glass
2013-06-11 18:14 ` [U-Boot] [PATCH v2 09/21] Support tracing in config.mk when enabled Simon Glass
2013-06-11 18:14 ` [U-Boot] [PATCH v2 10/21] Add trace support to generic board Simon Glass
2013-06-11 18:14 ` [U-Boot] [PATCH v2 11/21] Add proftool to decode profile data Simon Glass
2013-06-11 18:14 ` [U-Boot] [PATCH v2 12/21] sandbox: Support trace feature Simon Glass
2013-06-11 18:14 ` [U-Boot] [PATCH v2 13/21] Add a simple test for sandbox trace Simon Glass
2013-06-11 18:14 ` [U-Boot] [PATCH v2 14/21] Clarify bootm OS arguments Simon Glass
2013-06-11 18:14 ` [U-Boot] [PATCH v2 15/21] Refactor the bootm command to reduce code duplication Simon Glass
2013-06-27 13:40 ` Stefan Roese
2013-06-27 14:40 ` Tom Rini
2013-06-27 15:39 ` Simon Glass
2013-06-27 19:51 ` Simon Glass
2013-06-27 20:07 ` Tom Rini
2013-06-28 2:14 ` Simon Glass
2013-06-28 4:12 ` Stefan Roese
2013-06-28 5:44 ` Simon Glass
2013-06-28 6:58 ` Simon Glass [this message]
2013-06-28 7:04 ` Stefan Roese
2013-06-28 7:12 ` Simon Glass
2013-06-28 7:57 ` Simon Glass
2013-06-11 18:14 ` [U-Boot] [PATCH v2 16/21] Add a 'fake' go command to the bootm command Simon Glass
2013-06-11 18:14 ` [U-Boot] [PATCH v2 17/21] arm: Implement the 'fake' go command Simon Glass
2013-06-11 19:59 ` Albert ARIBAUD
2013-06-11 20:02 ` Simon Glass
2013-06-11 20:21 ` Albert ARIBAUD
2013-06-11 21:17 ` Simon Glass
2013-06-11 21:36 ` Albert ARIBAUD
2013-06-20 4:16 ` Simon Glass
2013-06-11 18:14 ` [U-Boot] [PATCH v2 18/21] exynos: Avoid function instrumentation for microsecond timer Simon Glass
2013-06-11 18:14 ` [U-Boot] [PATCH v2 19/21] exynos: config: Add tracing options Simon Glass
2013-06-11 18:14 ` [U-Boot] [PATCH v2 20/21] x86: Support tracing function Simon Glass
2013-06-11 18:14 ` [U-Boot] [PATCH v2 21/21] x86: config: Add tracing options Simon Glass
2013-06-26 20:24 ` [U-Boot] [PATCH v2 0/21] Add tracing functionality to U-Boot Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPnjgZ0fS9J1T2AoH-_bXGuzcuFTjopXBwoMCF9qWc5FLcm=Cg@mail.gmail.com' \
--to=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.