From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAD86C433F5 for ; Thu, 14 Oct 2021 15:16:11 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2C76C603E5 for ; Thu, 14 Oct 2021 15:16:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2C76C603E5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 597B78381C; Thu, 14 Oct 2021 17:13:21 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="bwBQsOGc"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7E5CE8356F; Thu, 14 Oct 2021 17:11:45 +0200 (CEST) Received: from mail-oi1-x236.google.com (mail-oi1-x236.google.com [IPv6:2607:f8b0:4864:20::236]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 931F9837CE for ; Thu, 14 Oct 2021 17:11:37 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-oi1-x236.google.com with SMTP id o204so8825156oih.13 for ; Thu, 14 Oct 2021 08:11:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=fogbyskOxLONVhMoihZbFtrvkbmCHB4Twp6n+glOURY=; b=bwBQsOGcDSqAc79ycnf0ehnlDUYB4uJvFe+k75pKEPqiLjYL4glZ6kaZtco5Krd1GH kU2JjUar/eLbQ5sF6c+maZj8FAeYbYS5vEX64prFp2bLNDZJgJ+oh9+CqWtNqqc+dbcK 41duKbTWC0dxxKBSolI1XGCdQtwElEP0pNezQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=fogbyskOxLONVhMoihZbFtrvkbmCHB4Twp6n+glOURY=; b=IoiL4yf/WY7h4YknSmXN0ki7sO2lMxUDARTv1rMd1DIBaUUpugWa2RT3EhYYtaFML2 rKMvlzNSA8uEnfNI+L+0n+k7z4teG1RSPuB69dHUX3XVcYptpTdydgyO4EZtXu0ykTnN iBdFemh6118ClPp/oLb6oXbkTHUZcaDDDdxbo07kswsdYUH300MSpFJKA7dB9u5ae0QU knRmwkmfFEDOs8wmQdQyyZiKyU8w/KQ60bw1kEwNKXg5cl/mhl0kvn78ryxAsC+S/5ES EjP3OyeIiRhMjJCA6fKV1+fueEG4XbTdmlwv8HvE7FBk0/mtTxm+6d5gHV0NDuXDi8Ry +pYw== X-Gm-Message-State: AOAM5322JdkqxYSZ+X1K/UkNVk6GU2ZjsQQDv5XWMOjpeRA3RHIAKUfX /skchc0iUlzfZs0LvQF8vq3FwMivaPpqxFfIKdIa2g== X-Google-Smtp-Source: ABdhPJy/NIbcTvNnwq8vgoNEaE/e9VznZLtVkNI7DwD1l6u4F6WnMOD1LpALQq6wUOC6WCbwm2MKLE2t6YOJPPTuMuo= X-Received: by 2002:aca:ab15:: with SMTP id u21mr4616999oie.53.1634224295182; Thu, 14 Oct 2021 08:11:35 -0700 (PDT) MIME-Version: 1.0 References: <20211013154557.28479-1-kabel@kernel.org> <20211013154557.28479-13-kabel@kernel.org> In-Reply-To: <20211013154557.28479-13-kabel@kernel.org> From: Simon Glass Date: Thu, 14 Oct 2021 09:11:20 -0600 Message-ID: Subject: Re: [PATCH v2 12/13] env: Use memcpy() instead of ad-hoc code to copy variable value To: =?UTF-8?B?TWFyZWsgQmVow7pu?= Cc: Tom Rini , U-Boot Mailing List , =?UTF-8?B?TWFyZWsgQmVow7pu?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Wed, 13 Oct 2021 at 09:46, Marek Beh=C3=BAn wrote: > > From: Marek Beh=C3=BAn > > Copy the value of the found variable into given buffer with memcpy() > instead of ad-hoc code. > > Signed-off-by: Marek Beh=C3=BAn > --- > cmd/nvedit.c | 18 ++++++------------ > 1 file changed, 6 insertions(+), 12 deletions(-) Reviewed-by: Simon Glass