From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] test/py: test_fs: add docstring comments to helper functions
Date: Tue, 2 Oct 2018 04:21:50 -0700 [thread overview]
Message-ID: <CAPnjgZ0jcK0rxes+PT9SKhmVi69y7rc5KTxVUB_2NY9k6CHCQA@mail.gmail.com> (raw)
In-Reply-To: <20180927070723.7741-2-takahiro.akashi@linaro.org>
On 27 September 2018 at 00:07, Akashi, Takahiro
<takahiro.akashi@linaro.org> wrote:
> From: "Akashi Takahiro" <takahiro.akashi@linaro.org>
>
> After Siomon's comment, add a descriptive comment (docstring) to each of
> helper functions in conftest.py. No functionality changed.
>
> Signed-off-by: Akashi Takahiro <takahiro.akashi@linaro.org>
> ---
> test/py/tests/test_fs/conftest.py | 133 ++++++++++++++++++++++++++++++
> 1 file changed, 133 insertions(+)
Reviewed-by: Simon Glass <sjg@chromium.org>
BTW you don't need to put a 'Returns' section if there is nothing returned.
next prev parent reply other threads:[~2018-10-02 11:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-27 7:03 [U-Boot] [PATCH 0/2] test/py: test_fs: follow up v3 of fat write patches Akashi, Takahiro
2018-09-27 7:07 ` [U-Boot] [PATCH 1/2] test/py: test_fs: remove fs_type argument from umount_fs() Akashi, Takahiro
2018-09-27 7:07 ` [U-Boot] [PATCH 2/2] test/py: test_fs: add docstring comments to helper functions Akashi, Takahiro
2018-10-02 11:21 ` Simon Glass [this message]
2018-10-07 0:28 ` [U-Boot] [U-Boot, " Tom Rini
2018-10-02 11:21 ` [U-Boot] [PATCH 1/2] test/py: test_fs: remove fs_type argument from umount_fs() Simon Glass
2018-10-07 0:28 ` [U-Boot] [U-Boot, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPnjgZ0jcK0rxes+PT9SKhmVi69y7rc5KTxVUB_2NY9k6CHCQA@mail.gmail.com \
--to=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.