From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Glass Date: Fri, 31 Mar 2017 22:24:03 -0600 Subject: [U-Boot] [PATCH v2 1/2] x86: Add SCU IPC driver for Intel MID platforms In-Reply-To: <1490529717.21738.28.camel@linux.intel.com> References: <20170315184206.8935-1-andriy.shevchenko@linux.intel.com> <1490016429.19767.113.camel@linux.intel.com> <1490529717.21738.28.camel@linux.intel.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Andy, On 26 March 2017 at 06:01, Andy Shevchenko wrote: > On Mon, 2017-03-20 at 15:27 +0200, Andy Shevchenko wrote: >> On Sun, 2017-03-19 at 20:30 -0600, Simon Glass wrote: >> > Hi Andy, >> > >> > On 15 March 2017 at 12:42, Andy Shevchenko >> > wrote: >> > > From: Felipe Balbi >> > > >> > > Intel MID platforms have few microcontrollers inside SoC, one of >> > > them >> > > is so called System Controller Unit (SCU). >> > > >> > > Here is the driver to communicate with microcontroller. >> > > >> > > Signed-off-by: Vincent Tinelli >> > > Signed-off-by: Felipe Balbi >> > > Signed-off-by: Andy Shevchenko >> > > --- >> > > arch/x86/Kconfig | 2 + >> > > arch/x86/include/asm/cpu.h | 1 + >> > > arch/x86/include/asm/scu.h | 28 ++++++++ >> > > arch/x86/lib/Makefile | 1 + >> > > arch/x86/lib/scu.c | 168 >> > > +++++++++++++++++++++++++++++++++++++++++++++ >> > > 5 files changed, 200 insertions(+) >> > > create mode 100644 arch/x86/include/asm/scu.h >> > > create mode 100644 arch/x86/lib/scu.c >> > >> > Since this is a v2 patch can you please include a change log? >> >> Yes. >> >> Common: >> - convert to use REGMAP instead of constant addressed IO >> - rewrite as UCLASS_SYSCON modules >> - move to arch/x86/lib since it's related to x86 only and there are >> already another UCLASS_SYSCON modules there >> >> SCU: >> - convert function documentation to have header and body and be >> consistent >> - shrink header and remove unneeded attributes >> - drop busy loop counter from 3m to 100k as per driver in Linux kernel >> >> PMU: >> - convert to be more generic and move Tangier related part to its own >> folder (the latter out of scope of this series) > > Should I resend with cover letter and changelog included? Yes that's a good idea, thanks. - Simon