From: Simon Glass <sjg@chromium.org>
To: Ajay Kaher <akaher@vmware.com>
Cc: trini@konsulko.com, mbrugger@suse.com, ptosi@google.com,
u-boot@lists.denx.de, amakhalov@vmware.com,
vbrahmajosyula@vmware.com, vsirnapalli@vmware.com,
tkundu@vmware.com, er.ajay.kaher@gmail.com
Subject: Re: [PATCH] board_r: Relocate OF_EMBED if NEEDS_MANUAL_RELOC only
Date: Wed, 15 Mar 2023 13:42:57 -0600 [thread overview]
Message-ID: <CAPnjgZ0nttcSeF2ADMAdJ9DqoScGLmWVkBuZZkO1uv=9Skhx0A@mail.gmail.com> (raw)
In-Reply-To: <1678908250-1078-1-git-send-email-akaher@vmware.com>
Hi Ajay,
On Wed, 15 Mar 2023 at 13:24, Ajay Kaher <akaher@vmware.com> wrote:
>
> > On Fri, Sep 09, 2022 at 09:16:18PM +0100, Pierre-Clément Tosi wrote:
> >
> >> When the embedded device tree is pointed to by the __dtb_dt_*begin
> >> symbols, it seems to be covered by the early relocation code and doesn't
> >> need to be manually patched.
> >>
> >> Cc: Simon Glass <sjg@chromium.org>
> >> Signed-off-by: Pierre-Clément Tosi <ptosi@google.com>
> >
> > Applied to u-boot/master, thanks!
>
> Getting following error on Rpi3 board and fail to boot with u-boot upstream
> commit 76f921eb95d5b814f973a263187db509d6f03903:
>
> ERROR: invalid device tree
> EFI LOAD FAILED: continuing...
>
> As per bdinfo:
> fdt_blob = 0x00000000000f4b00
>
> Would like to understand the reasoning of this upstream commit
> 76f921eb95d5b814f973a263187db509d6f03903 and looking for proper fix for Rpi3.
>
> -Ajay
Did you bisect to that patch?
The proper fix would be to get away from OF_EMBED which is not allowed
in production boards. Can you post the full console log so I can see
what happens before the error?
The commit does not look correct to me. This is nothing to do with the
horrible NEEDS_MANUAL_RELOC which is only needed on m68k I think now.
It is because we have moved the executable containing the DT. The DT
in the old position may be overwritten by loading something.
Regards,
Simon
next prev parent reply other threads:[~2023-03-15 19:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 20:16 [PATCH] board_r: Relocate OF_EMBED if NEEDS_MANUAL_RELOC only Pierre-Clément Tosi
2022-09-29 20:07 ` Tom Rini
2023-03-15 19:24 ` Ajay Kaher
2023-03-15 19:42 ` Simon Glass [this message]
2023-03-16 5:51 ` Ajay Kaher
2023-03-16 19:25 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPnjgZ0nttcSeF2ADMAdJ9DqoScGLmWVkBuZZkO1uv=9Skhx0A@mail.gmail.com' \
--to=sjg@chromium.org \
--cc=akaher@vmware.com \
--cc=amakhalov@vmware.com \
--cc=er.ajay.kaher@gmail.com \
--cc=mbrugger@suse.com \
--cc=ptosi@google.com \
--cc=tkundu@vmware.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=vbrahmajosyula@vmware.com \
--cc=vsirnapalli@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.