Re: [PATCH v4 1/8] binman: add support for skipping file concatenation for mkimage

From: Simon Glass <sjg@chromium.org>
To: Quentin Schulz <foss+uboot@0leil.net>
Cc: Bharat Gooty <bharat.gooty@broadcom.com>,
	 Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>,
	 Philipp Tomsich <philipp.tomsich@vrull.eu>,
	Kever Yang <kever.yang@rock-chips.com>,
	 Jagan Teki <jagan@amarulasolutions.com>,
	Alper Nebi Yasak <alpernebiyasak@gmail.com>,
	 Heinrich Schuchardt <xypron.glpk@gmx.de>,
	Heiko Thiery <heiko.thiery@gmail.com>,
	U-Boot Mailing List <u-boot@lists.denx.de>,
	 Quentin Schulz <quentin.schulz@theobroma-systems.com>
Subject: Re: [PATCH v4 1/8] binman: add support for skipping file concatenation for mkimage
Date: Thu, 18 Aug 2022 02:17:03 -0600	[thread overview]
Message-ID: <CAPnjgZ0qFci09em5ChPNek=mLUuzQTykQt7u7V5TFejkBb9KKw@mail.gmail.com> (raw)
In-Reply-To: <20220803121906.2629478-2-foss+uboot@0leil.net>

Hi Quentin,

On Wed, 3 Aug 2022 at 06:19, Quentin Schulz <foss+uboot@0leil.net> wrote:
>
> From: Quentin Schulz <quentin.schulz@theobroma-systems.com>
>
> Some image types handled by mkimage require the datafiles to be passed
> independently (-d data1:data2) for specific handling of each. A
> concatenation of datafiles prior to passing them to mkimage wouldn't
> work.
>
> That is the case for rkspi for example which requires page alignment
> and only writing 2KB every 4KB.
>
> This adds the ability to tell binman to pass the datafiles without
> prior concatenation to mkimage, by adding the multiple-data-files
> boolean property to the mkimage node.
>
> Cc: Quentin Schulz <foss+uboot@0leil.net>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
> ---
>  tools/binman/entries.rst      | 22 +++++++++++++++++++
>  tools/binman/etype/mkimage.py | 41 +++++++++++++++++++++++++++++++----
>  2 files changed, 59 insertions(+), 4 deletions(-)

Somehow I missed this one, sorry.

It needs a test (try 'binman test -T' to see that it breaks code coverage).

Regards,
Simon