From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1C2EC433EF for ; Thu, 14 Oct 2021 15:16:23 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1C742603E5 for ; Thu, 14 Oct 2021 15:16:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1C742603E5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 841E783821; Thu, 14 Oct 2021 17:13:24 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="jHJusTpf"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E2298837D9; Thu, 14 Oct 2021 17:11:47 +0200 (CEST) Received: from mail-oo1-xc2b.google.com (mail-oo1-xc2b.google.com [IPv6:2607:f8b0:4864:20::c2b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9D219837D0 for ; Thu, 14 Oct 2021 17:11:37 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-oo1-xc2b.google.com with SMTP id k11-20020a4aa5cb000000b002b73749f3cdso1331100oom.4 for ; Thu, 14 Oct 2021 08:11:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=+o4nXFETJt+BTxHBApOkHjCwt0ydxbaZU85Ir85tegA=; b=jHJusTpf02QT3lSkv9RBubAlQ1N71Xu6kEywFVOg3LMbH6aFKsMxaR4qtfRUYC5rGb OlC7bw96pnb4/J6AeHe9mHY+GIp2kO6CEjymIAVoidXM6vWPTasbiobTIsI+g9xkzB7q 6FwFVm2R63SvmPwJ5MklFiBMpoOpkfQcMsdyc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=+o4nXFETJt+BTxHBApOkHjCwt0ydxbaZU85Ir85tegA=; b=DW6YxocyOl8Ns9Nrk3qQ52mE6TxGV65bMvPFZAiuLpeA1ubaEsi5K3CFVP3KF+zAWB DstVmx7aWmf1vS2HcTSQkFyW/ds2er9wiU31ZSVYiR8L2ap6D1omTWpy/xTrKMwwE2yN +UBydFTwztpYtSvlNakf2Hfv4GduQ1D6SXH7IppCd9/QMXdO+5HIhYpxwFsTWdXbOCmS 6BN7A7DPa+1xrQ6Bm8jr1/iw0L+8C4NjVDBSHNZ1O34un9dTc1BwpVd9QNhHhtWUsLvo k6LA8tYUdNkyq7hte1BMFiNJOYOqonWcwwmIeBTxm/tY0Ql8J/GAF5Tz5YhvzipbjgWF D8fg== X-Gm-Message-State: AOAM532lRL7n9hs698i2DfBroURp//CeBsa0aawnH1P6Q5jI/IXcUDrr jhJV78zgouaJS3ymAvG2r6dua/HL/8/qfHCOcz2zTA== X-Google-Smtp-Source: ABdhPJybyAmVSAJdjV3ygYB0OHjTiks+v27wRk9vWNPq88jsP1Y7iyrAYuRkUfU7R81/tBg353oJTQjT5/tI2voInHY= X-Received: by 2002:a4a:d6c7:: with SMTP id j7mr4598030oot.36.1634224295976; Thu, 14 Oct 2021 08:11:35 -0700 (PDT) MIME-Version: 1.0 References: <20211013154557.28479-1-kabel@kernel.org> <20211013154557.28479-14-kabel@kernel.org> In-Reply-To: <20211013154557.28479-14-kabel@kernel.org> From: Simon Glass Date: Thu, 14 Oct 2021 09:11:22 -0600 Message-ID: Subject: Re: [PATCH v2 13/13] env: Move non-cmd specific env functions to env/common.c To: =?UTF-8?B?TWFyZWsgQmVow7pu?= Cc: Tom Rini , U-Boot Mailing List , =?UTF-8?B?TWFyZWsgQmVow7pu?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Wed, 13 Oct 2021 at 09:46, Marek Beh=C3=BAn wrote: > > From: Marek Beh=C3=BAn > > Move the following functions from cmd/nvedit.c to env/common.c: > env_set_ulong() > env_set_hex() > env_get_hex() > eth_env_get_enetaddr() > eth_env_set_enetaddr() > env_get() > from_env() > env_get_f() > env_get_ulong() > since these functions are not specific for U-Boot's CLI. > > We leave env_set() in cmd/nvedit.c, since it calls _do_env_set(), which > is a static function in that file. > > Signed-off-by: Marek Beh=C3=BAn > --- > cmd/nvedit.c | 185 ------------------------------------------------- > env/common.c | 190 +++++++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 190 insertions(+), 185 deletions(-) Reviewed-by: Simon Glass Subject: Move non-cmd-specific env functions// or maybe Move non-cli env functions...