From mboxrd@z Thu Jan  1 00:00:00 1970
From: Simon Glass <sjg@chromium.org>
Date: Fri, 31 Mar 2017 22:21:58 -0600
Subject: [U-Boot] [PATCH 3/7] arm: omap-common: sata: prepare driver for
	DM conversion
In-Reply-To: <1490358287-15304-4-git-send-email-jjhiblot@ti.com>
References: <1490358287-15304-1-git-send-email-jjhiblot@ti.com>
 <1490358287-15304-4-git-send-email-jjhiblot@ti.com>
Message-ID: <CAPnjgZ0wDYJ6WncYNsiS0kRcS5ogyJ=n44RU31i_XrQDjTa67A@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi,

On 24 March 2017 at 06:24, Jean-Jacques Hiblot <jjhiblot@ti.com> wrote:
> From: Mugunthan V N <mugunthanvnm@ti.com>
>
> Prepare sata driver for DM conversion by abstracting sata phy
> init to seperate function.
>
> Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>
> Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
> ---
>  arch/arm/mach-omap2/sata.c | 13 +++++++++----
>  include/sata.h             |  2 ++
>  2 files changed, 11 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/sata.c b/arch/arm/mach-omap2/sata.c
> index 217f1c9..dce432b 100644
> --- a/arch/arm/mach-omap2/sata.c
> +++ b/arch/arm/mach-omap2/sata.c
> @@ -32,16 +32,21 @@ struct omap_pipe3 sata_phy = {
>         .dpll_map = dpll_map_sata,
>  };
>
> +int enable_sata_phy(void)

We should not be calling board functions from the driver. Can you
instead add a SATA PHY uclass / driver?

> +{
> +       sata_phy.power_reg = (void __iomem *)(*ctrl)->control_phy_power_sata;
> +
> +       /* Power up the PHY */
> +       return phy_pipe3_power_on(&sata_phy);
> +}
> +
>  #ifndef CONFIG_DM_SCSI
>  int init_sata(int dev)
>  {
>         int ret;
>         u32 val;
>
> -       sata_phy.power_reg = (void __iomem *)(*ctrl)->control_phy_power_sata;
> -
> -       /* Power up the PHY */
> -       phy_pipe3_power_on(&sata_phy);
> +       enable_sata_phy();
>
>         /* Enable SATA module, No Idle, No Standby */
>         val = TI_SATA_IDLE_NO | TI_SATA_STANDBY_NO;
> diff --git a/include/sata.h b/include/sata.h
> index d18cc9a..583b72d 100644
> --- a/include/sata.h
> +++ b/include/sata.h
> @@ -18,4 +18,6 @@ int sata_port_status(int dev, int port);
>  extern struct blk_desc sata_dev_desc[];
>  #endif
>
> +int enable_sata_phy(void);
> +
>  #endif
> --
> 1.9.1
>


Regards,
Simon