From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2ABA8C11F69 for ; Mon, 5 Jul 2021 15:30:17 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A325D619D1 for ; Mon, 5 Jul 2021 15:30:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A325D619D1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E962082C02; Mon, 5 Jul 2021 17:30:13 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="M4gUda5z"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id DFC3782BE2; Mon, 5 Jul 2021 17:30:09 +0200 (CEST) Received: from mail-oi1-x229.google.com (mail-oi1-x229.google.com [IPv6:2607:f8b0:4864:20::229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3299E82BE2 for ; Mon, 5 Jul 2021 17:30:03 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-oi1-x229.google.com with SMTP id 10so6376178oiq.9 for ; Mon, 05 Jul 2021 08:30:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zXFN0Xzw+WYv5D9EPfT4aQMD5hufna9EnvjL7fKX2FI=; b=M4gUda5zSC47XhEGRjFx2naOMfY5p1ISxCLfL5eJyVSNvqJvsAQIIEyJf1p2Pp1kFe 4joQQLePOroKBCWhxVZJVoI2iRIYGzxubPR3aIS8Rs8lJOHLznBwuV/FMY3Cb3BEe2JB e1S+7Ctau/6KISArmLdKlRaN7N3wMzxhZx7XY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zXFN0Xzw+WYv5D9EPfT4aQMD5hufna9EnvjL7fKX2FI=; b=kU9cf80AljI7fNrNp7fTywyIEfzh5iSC6sH1w3e5MxGOfoFDw2B60c8wNHtyCrH4aL tBTz4s7yKs587uqVHCQceg0Ql4KYL30Bg0QMZtrZd40f0Ph+vjsET2YS8uJDPRh89yq/ 8idRk4kP2G8bvz5Xus5i+CbAXsv1JpVStp3mbv/8CaLYdtA9wacerv7sdKyhARAh9vJs ugAcOo+AamKoSuAEWiv8aY3OJjDktVJhfxv5u+m9oEmhnkm7Mcs42Z7cLz/4ctakoP+c zqcK0d12M5qYkEC07+9ADIkTW0BGRfy2XHIZmsCirlLEbyDp+vTgyAV5CP7yvcnD6dLL cMxg== X-Gm-Message-State: AOAM532t/qadL57QssPqKQns7PiRLNOs+H+8TyHz49JKdaU1V2D1LrqD ncLe6BoxUhaxT4ZKe+MyCbIGW2BzLitVS7HiuFG/B1KWqdN3CQ== X-Google-Smtp-Source: ABdhPJzJ5CCpg1MVwDv6OVe9+PPR7OzVJRKZyPj9MacF1bLk3IgmqEwn9CCq9wygmcw2h/kzDxp2Nhc4EBgRgStoldk= X-Received: by 2002:aca:fc07:: with SMTP id a7mr391488oii.150.1625499001289; Mon, 05 Jul 2021 08:30:01 -0700 (PDT) MIME-Version: 1.0 References: <20210701061611.957918-1-seanga2@gmail.com> <20210701061611.957918-5-seanga2@gmail.com> In-Reply-To: <20210701061611.957918-5-seanga2@gmail.com> From: Simon Glass Date: Mon, 5 Jul 2021 09:29:47 -0600 Message-ID: Subject: Re: [RFC PATCH 04/28] cli: lil: Remove most functions by default To: Sean Anderson Cc: U-Boot Mailing List , Tom Rini , =?UTF-8?B?TWFyZWsgQmVow7pu?= , Wolfgang Denk , Roland Gaudig , Heinrich Schuchardt , Kostas Michalopoulos Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Thu, 1 Jul 2021 at 00:16, Sean Anderson wrote: > > This helps reduce the size impact of LIL to approximately that of hush. The > builtin functions have been chosen to roughly match the functionality > present in hush. In addition, arithmetic is removed from expr to reduce > size further. > > Signed-off-by: Sean Anderson > --- > > cmd/Kconfig | 10 ++++++ > common/cli_lil.c | 83 +++++++++++++++++++++++++++--------------------- > 2 files changed, 57 insertions(+), 36 deletions(-) Reviewed-by: Simon Glass