All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: Heinrich Schuchardt <xypron.glpk@gmx.de>
Cc: "Milan P. Stanić" <mps@arvanta.net>,
	"U-Boot Mailing List" <u-boot@lists.denx.de>
Subject: Re: [BUG] sandbox: NO_SDL=1 gcc: error: arch/sandbox/cpu/sdl.o: No such file or directory
Date: Thu, 13 Jan 2022 06:41:35 -0700	[thread overview]
Message-ID: <CAPnjgZ0yqn_MjZ3uTLCrRp1-ifskKJgTmqmA4x31JZqVYn=Qgg@mail.gmail.com> (raw)
In-Reply-To: <4d2205b3-9022-6529-762c-8b015d37d5f8@gmx.de>

Hi Heinrich,

On Mon, 10 Jan 2022 at 16:22, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>
> Hello Simon,
>
> compiling with SDL fails on Alpine Linux:
> https://gitlab.alpinelinux.org/alpine/aports/-/issues/13411
>
> So I tried NO_SDL:
>
> make sandbox_defconfig NO_SDL=1
> make menuconfig # CONFIG_ETH_SANDBOX_RAW=n
> make -j4 NO_SDL=1
>
> But I got an error
> gcc: error: arch/sandbox/cpu/sdl.o: No such file or directory

Do you need mrproper first? I don't hit that problem.

I see that I broke it...it needs a static inline for
sandbox_sdl_remove_display().

>
> Can't we make CONFIG_SANDBOX_SDL a Kconfig symbol to get rid of the
> command line symbol?
>
> We already have CONFIG_SANDBOX_VIDEO_SDL. Do we need two symbols?

You mean, manually change the defconfig file? I suppose we could do
that, but it is harder for people to do.

In any case, we should add this case to CI.

Regards,
Simon

  reply	other threads:[~2022-01-13 13:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-10 23:22 [BUG] sandbox: NO_SDL=1 gcc: error: arch/sandbox/cpu/sdl.o: No such file or directory Heinrich Schuchardt
2022-01-13 13:41 ` Simon Glass [this message]
2022-01-13 18:07   ` Heinrich Schuchardt
2022-01-13 18:09     ` Simon Glass
2022-01-15 18:47   ` Heinrich Schuchardt
2022-01-16 21:14     ` Milan P. Stanić
2022-01-16 22:41       ` Heinrich Schuchardt
2022-01-16 23:11         ` Milan P. Stanić

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPnjgZ0yqn_MjZ3uTLCrRp1-ifskKJgTmqmA4x31JZqVYn=Qgg@mail.gmail.com' \
    --to=sjg@chromium.org \
    --cc=mps@arvanta.net \
    --cc=u-boot@lists.denx.de \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.