From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D965C433F5 for ; Thu, 14 Oct 2021 15:15:59 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DC33C60F4A for ; Thu, 14 Oct 2021 15:15:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DC33C60F4A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0E4398380F; Thu, 14 Oct 2021 17:13:19 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="Ho8290+K"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 810C3837D2; Thu, 14 Oct 2021 17:11:39 +0200 (CEST) Received: from mail-ot1-x32f.google.com (mail-ot1-x32f.google.com [IPv6:2607:f8b0:4864:20::32f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D3CF18356F for ; Thu, 14 Oct 2021 17:11:31 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-ot1-x32f.google.com with SMTP id k2-20020a056830168200b0054e523d242aso8676897otr.6 for ; Thu, 14 Oct 2021 08:11:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=xanKYNPxm+Ru17+fJiSGlqn79QzT0QBMQ54jjhPX8cw=; b=Ho8290+K+1on6wUACI71y1sy87OZniREFFFGj2tVL5EkZtaf2I81KpoY+Rn6xGRkip 7toMrX0QX7Nmw05JvwGUqzwFzZuVdtoFs/ORDhpG3KmokN1+BBDGU5qveNxsy9o9Odd1 bnZlE5SHDPqzUVd7atYytgo375IbvSW6ODnYs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=xanKYNPxm+Ru17+fJiSGlqn79QzT0QBMQ54jjhPX8cw=; b=SAZDMZBwmbwVv0eziD+6cGU6Gum0V3sxpp9op5oOTP5SFp8jXr+ZgPEiKiArdh++9K eiZOh3PneaGxGMjx2E5y/l6y61UWx3znuHDPm5IQzi3jB5eUBDeWzSLfeEsHWBAi1Du3 Uev4agPBq6mN1I+UrO1Ip70+MrQp5Y917OP1ZIsZyq1D1fb/+sFw/dDgeAx/xl8eFVyC TfF37CyOG2eJ9azOab8lamD3skbgIf1t5LPoVKKSOoGKOAe86Nv0a3ZyavhPIu99ziJm S7LaPvBt3uMdtwNLuvnCu9jLkDQQFQHZ6HzsWOkTyIz2bZQzKIqDFd2mMk9M8H3QoVNe yrfg== X-Gm-Message-State: AOAM531X38aOCwDvZphGrUvmPz0KzkkkHWj37g+KFwLHPd0HVrwE5tlw tahnkM0xpntSL/drpB8VdOx7iYCEi36PEUEK1Dt8jg== X-Google-Smtp-Source: ABdhPJxdw84i+mJBfKndjGK5QpScAa+loawC7tSv+hwSpG+CaRrYWgUFH4Po/iiH5l/iwa81uYYaNRufXOB90+LHmyA= X-Received: by 2002:a9d:7b49:: with SMTP id f9mr3085160oto.11.1634224290215; Thu, 14 Oct 2021 08:11:30 -0700 (PDT) MIME-Version: 1.0 References: <20211013154557.28479-1-kabel@kernel.org> <20211013154557.28479-10-kabel@kernel.org> In-Reply-To: <20211013154557.28479-10-kabel@kernel.org> From: Simon Glass Date: Thu, 14 Oct 2021 09:11:15 -0600 Message-ID: Subject: Re: [PATCH v2 09/13] env: Use string pointer instead of indexes in env_get_f() To: =?UTF-8?B?TWFyZWsgQmVow7pu?= Cc: Tom Rini , U-Boot Mailing List , =?UTF-8?B?TWFyZWsgQmVow7pu?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Wed, 13 Oct 2021 at 09:46, Marek Beh=C3=BAn wrote: > > From: Marek Beh=C3=BAn > > Since we no longer use env_get_char() to access n-th character of > linearized environment data, but rather access the arrays themselves, we > can convert the iteration to use string pointers instead of position > indexes. > > Signed-off-by: Marek Beh=C3=BAn > --- > cmd/nvedit.c | 34 +++++++++++++++++----------------- > 1 file changed, 17 insertions(+), 17 deletions(-) Reviewed-by: Simon Glass