From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABF52C433EF for ; Fri, 5 Nov 2021 02:07:57 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 31F2F60E90 for ; Fri, 5 Nov 2021 02:07:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 31F2F60E90 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3F4688378E; Fri, 5 Nov 2021 03:05:40 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="UMf+z6kr"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3C09C836EF; Fri, 5 Nov 2021 03:04:16 +0100 (CET) Received: from mail-oi1-x22f.google.com (mail-oi1-x22f.google.com [IPv6:2607:f8b0:4864:20::22f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E519683715 for ; Fri, 5 Nov 2021 03:03:45 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-oi1-x22f.google.com with SMTP id d12so8921702oij.5 for ; Thu, 04 Nov 2021 19:03:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=5MEJ9d9pFD4/Ax8OT1twKXsjmbmG55eZ0psn/tb0wHc=; b=UMf+z6kr31g7oJbAoKePnLCD6TFFEPyO+yfaG8LtgtYQ9SbTqJWmQ4GcRB0hOCdrGL dMj5PBU+cXD6pjwqsnENZXTDNlOqGCorFp/b2r5VhvqQQhaBRm8M5agA3xfY2TD76geL YVIpV5OoGrqVlFy3uqdQWgUujbUKg36pNKAlM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=5MEJ9d9pFD4/Ax8OT1twKXsjmbmG55eZ0psn/tb0wHc=; b=ZzqRYN5qilZNjhYwp5o6wmMy/28Msy4IyX9cDjCtM2bf8hztDtTDCsZpzrT+FLM12E C59G16uyDMSI/WKFJDXxt3T1U88wK76agbILs9+LbL39Ps/7+NStsr6bffrVgPrGevZI uvI7+iL0cp2Fwu5CU3hPvd+HTLbmyppwP1KX7v21LM38zHK8rz5gwSjuEyDBMB1DpfCO /kFRq9xE1X3hjx4LPpL3qklrb1J+iGwzk1Lli1g1VMOp71qERSv3RyyQl0Le0sPtSZ0A VWE+5KGmHl411+3PAyLqS8AZEahaguIcY5MnKMmGMFW1dlWc0VVVabsmNRr18to/KMNq AFWw== X-Gm-Message-State: AOAM530jlxUvLdtSoZhQn6+TJ3RF9DnTKBt+KnauYE04gAeDa6i6sySp THdF9FuB12UlijJFJ09noci3ig9pZ0P6/dDRQ07Xdnai6OU= X-Google-Smtp-Source: ABdhPJyl7ESXCYNiiUmNvWWorbiwMtO7MJ7sk3GROAYsCIhorSgpAPhgpv+f6jqlb5aIrXIpwVxGpnd4pqOBOxEVPUU= X-Received: by 2002:aca:4283:: with SMTP id p125mr19266439oia.81.1636077824370; Thu, 04 Nov 2021 19:03:44 -0700 (PDT) MIME-Version: 1.0 References: <20211103232332.2737-1-kabel@kernel.org> <20211103232332.2737-12-kabel@kernel.org> In-Reply-To: <20211103232332.2737-12-kabel@kernel.org> From: Simon Glass Date: Thu, 4 Nov 2021 20:02:33 -0600 Message-ID: Subject: Re: [PATCH v2 11/12] arm: mvebu: Espressobin: Use new API for setting default env at runtime To: =?UTF-8?B?TWFyZWsgQmVow7pu?= Cc: =?UTF-8?Q?Pali_Roh=C3=A1r?= , u-boot@lists.denx.de, =?UTF-8?B?TWFyZWsgQmVow7pu?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Wed, 3 Nov 2021 at 17:23, Marek Beh=C3=BAn wrote: > > From: Marek Beh=C3=BAn > > ESPRESSObin's board code uses an ad-hoc solution for ensuring that > ethaddrs are not overwritten by `env default -a` command and that the > `fdtfile` is set to correct value when `env default -a` is called. > > This ad-hoc solution is overwriting the default_environment[] buffer in > board_late_init(). > > Since now we have a specific API for overwriting default environment, > convert this ad-hoc code to this new API. > > Signed-off-by: Marek Beh=C3=BAn > --- > board/Marvell/mvebu_armada-37xx/board.c | 135 +++++++++++++------- > configs/mvebu_espressobin-88f3720_defconfig | 1 + > include/configs/mvebu_armada-37xx.h | 17 +-- > 3 files changed, 90 insertions(+), 63 deletions(-) Reviewed-by: Simon Glass