All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v8 0/38] Switch over to real Kbuild
Date: Tue, 18 Feb 2014 22:09:21 -0800	[thread overview]
Message-ID: <CAPnjgZ1-=heQEjwfm1TdVsEVz5BiP-G1tGh+_yBkpsuyUcQsSA@mail.gmail.com> (raw)
In-Reply-To: <20140218180236.A12A.AA925319@jp.panasonic.com>

Hi Masahiro,

On 18 February 2014 01:02, Masahiro Yamada <yamada.m@jp.panasonic.com> wrote:
> Hello Simon,
>
>
>>
>> I'm not sure whether to start a new thread or not, but here in one
>> observations which might be useful.
>>
>> With current master, a 'null' build (with nothing changed) takes about
>> 5s for me.
>>
>> time CROSS_COMPILE=/opt/linaro/gcc-linaro-arm-linux-gnueabihf-4.8-2013.08_linux/bin/arm
>> -linux-gnueabihf- ARCH=arm make -j1
>> real 0m4.978s
>> user 0m1.144s
>> sys 0m0.360s
>>
>>
>> With the kbuild series, it takes a lot longer:
>>
>> real 0m46.600s
>> user 0m17.628s
>> sys 0m8.664s
>
> Thanks for your feedback.
>
> Hmm, Kbuild is 9 times slower on your computer.
> This is a big difference. (It was about 1.6 x slower on my box.)
>
> I don't know where such a difference came from.

Note this is a 32-core machine.

>
>> There seem to be noticeable pauses between things happening. I'm not
>> quite sure how to dig into it more. Is it possible that cc-option is
>> no-longer caching the various compiler options?
>
> I guess it's possible.
>
> Is sandbox build slow as well?
> Sandbox has no cc-option.
> If cc-option is the cause of pauses, sandbox build
> should be faster.

Yes actually sandbox is pretty fast.

>
> Anyway, evaluating cc-option multiple times isn't nice
> and its optimization is on my TODO list.
>
> Historically, U-Boot has included all
> config.mk (arch/*/config.mk and board/*/config.mk)
> every time descending into subdirectories.
> That means cc-options are evaluated over and over again.
> Caching cc-option is one of work arounds, but we should not
> revive it.
>
> What we should do is to include arch/*/config.mk and board/*/config.mk
> only once at the top Makefile and export options.

That sounds good to me. Thanks for looking at it.

Regards,
Simon

  reply	other threads:[~2014-02-19  6:09 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-29 12:25 [U-Boot] [PATCH v8 0/38] Switch over to real Kbuild Masahiro Yamada
2014-01-29 12:25 ` [U-Boot] [PATCH v8 01/38] .gitignore: ingore files generated by Kbuild Masahiro Yamada
2014-01-29 12:25 ` [U-Boot] [PATCH v8 02/38] Makefile.host.tmp: add a new script to refactor tools Masahiro Yamada
2014-01-29 12:26 ` [U-Boot] [PATCH v8 03/38] tools: convert makefiles to kbuild style Masahiro Yamada
2014-01-29 12:26 ` [U-Boot] [PATCH v8 04/38] board: samsung: refactor host programs Masahiro Yamada
2014-01-29 12:26 ` [U-Boot] [PATCH v8 05/38] examples: Use scripts/Makefile.build Masahiro Yamada
2014-01-29 12:26 ` [U-Boot] [PATCH v8 06/38] nand-spl: " Masahiro Yamada
2014-01-29 12:26 ` [U-Boot] [PATCH v8 07/38] Makfile: move suffix rules to Makefile.build Masahiro Yamada
2014-01-29 12:26 ` [U-Boot] [PATCH v8 08/38] Makefile: move some variable definitions to the top Makefile Masahiro Yamada
2014-01-29 12:26 ` [U-Boot] [PATCH v8 09/38] Makefile: move BFD_ROOT_DIR to tools/gdb/Makefile Masahiro Yamada
2014-01-29 12:26 ` [U-Boot] [PATCH v8 10/38] kbuild: import Kbuild.include from linux v3.13 tag Masahiro Yamada
2014-01-29 12:26 ` [U-Boot] [PATCH v8 11/38] kbuild: Use Kbuild.include Masahiro Yamada
2014-01-29 12:26 ` [U-Boot] [PATCH v8 12/38] Makefile: move more flags to the top Makefile Masahiro Yamada
2014-01-29 12:26 ` [U-Boot] [PATCH v8 13/38] Makefile: refactor include path settings Masahiro Yamada
2014-01-29 12:26 ` [U-Boot] [PATCH v8 14/38] Makefile: move more stuff to top Makefile Masahiro Yamada
2014-01-29 12:26 ` [U-Boot] [PATCH v8 15/38] Makefile: move some flags to spl/Makefile Masahiro Yamada
2014-01-29 12:26 ` [U-Boot] [PATCH v8 16/38] Makefile: move some flags to examples makefiles Masahiro Yamada
2014-01-29 12:26 ` [U-Boot] [PATCH v8 17/38] kbuild: change out-of-tree build Masahiro Yamada
2014-01-29 12:26 ` [U-Boot] [PATCH v8 18/38] kbuild: add dummy obj-y to create built-in.o Masahiro Yamada
2014-01-29 12:26 ` [U-Boot] [PATCH v8 19/38] Makefile: rename scripts/Makefile.build to scripts/Makefile.build.tmp Masahiro Yamada
2014-01-29 12:26 ` [U-Boot] [PATCH v8 20/38] kbuild: import more build scripts from Linux v3.13 tag Masahiro Yamada
2014-01-29 12:26 ` [U-Boot] [PATCH v8 21/38] kbuild: use Linux Kernel build scripts Masahiro Yamada
2014-01-29 12:26 ` [U-Boot] [PATCH v8 22/38] kbuild: delete temporary " Masahiro Yamada
2014-01-29 12:26 ` [U-Boot] [PATCH v8 23/38] kbuild: move some lines to more suitable place Masahiro Yamada
2014-01-29 12:26 ` [U-Boot] [PATCH v8 24/38] kbuild: convert some make rules to Kbuild style Masahiro Yamada
2014-01-29 12:26 ` [U-Boot] [PATCH v8 25/38] kbuild: move include directives of board configuration files Masahiro Yamada
2014-01-29 12:26 ` [U-Boot] [PATCH v8 26/38] kbuild: generate {spl, tpl}-autoconf.mk only when it is necessary Masahiro Yamada
2014-01-29 12:26 ` [U-Boot] [PATCH v8 27/38] Makefile: remove a cleaning target "tidy" Masahiro Yamada
2014-01-29 12:26 ` [U-Boot] [PATCH v8 28/38] kbuild: change the top Makefile to more Kbuild-ish structure Masahiro Yamada
2014-01-29 12:26 ` [U-Boot] [PATCH v8 29/38] examples: move api/ and standalone/ entry to examples/Makefile Masahiro Yamada
2014-01-29 12:26 ` [U-Boot] [PATCH v8 30/38] kbuild: refactor Makefile and spl/Makefile more Masahiro Yamada
2014-01-29 12:26 ` [U-Boot] [PATCH v8 31/38] Makefile: Do not pass MTD_VERSION from the top Makefile Masahiro Yamada
2014-01-29 12:26 ` [U-Boot] [PATCH v8 32/38] Makefile: refactor tools-all targets Masahiro Yamada
2014-01-29 12:26 ` [U-Boot] [PATCH v8 33/38] kbuild: use scripts/Makefile.clean Masahiro Yamada
2014-01-29 12:26 ` [U-Boot] [PATCH v8 34/38] kbuild: support simultaneous board configuration and "make all" Masahiro Yamada
2014-01-29 12:26 ` [U-Boot] [PATCH v8 35/38] kbuild: check clean source and generate Makefile for out-of-tree build Masahiro Yamada
2014-01-29 12:26 ` [U-Boot] [PATCH v8 36/38] board: sandburst: delete FORCEBUILD Masahiro Yamada
2014-01-29 12:26 ` [U-Boot] [PATCH v8 37/38] kbuild: Do not generate .*.su files at the top directory Masahiro Yamada
2014-01-29 12:26 ` [U-Boot] [PATCH v8 38/38] tools/env: cross-compile fw_printenv without setting HOSTCC Masahiro Yamada
2014-01-30 21:35 ` [U-Boot] [PATCH v8 0/38] Switch over to real Kbuild Andreas Bießmann
2014-01-31  1:48   ` Masahiro Yamada
2014-01-31  9:12 ` Masahiro Yamada
2014-02-01 12:09   ` Tom Rini
2014-01-31 20:35 ` Simon Glass
2014-02-03  3:46   ` Masahiro Yamada
2014-02-06 21:10     ` Tom Rini
2014-02-16  1:30       ` Simon Glass
2014-02-16  2:51         ` Simon Glass
2014-02-18  9:02           ` Masahiro Yamada
2014-02-19  6:09             ` Simon Glass [this message]
2014-02-19  9:51               ` Masahiro Yamada
2014-02-19 17:28             ` Tom Rini
2014-02-20  8:25               ` Masahiro Yamada
2014-02-20 13:29                 ` Tom Rini
2014-02-18 14:44         ` Tom Rini
2014-02-19  1:57           ` Masahiro Yamada
2014-02-19 12:54             ` Tom Rini
2014-02-19 13:28               ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPnjgZ1-=heQEjwfm1TdVsEVz5BiP-G1tGh+_yBkpsuyUcQsSA@mail.gmail.com' \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.