All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 08/13] fastboot: Fix parameter types in _fb_nand_write
Date: Mon, 14 May 2018 13:52:32 -0600	[thread overview]
Message-ID: <CAPnjgZ1-AmvUWPmQMcaVH3SuFA9cSdKzx0W4E==scEyHYJZBmQ@mail.gmail.com> (raw)
In-Reply-To: <1526288948-24977-9-git-send-email-alex.kiernan@gmail.com>

On 14 May 2018 at 03:09, Alex Kiernan <alex.kiernan@gmail.com> wrote:
> Compiling on a 64 bit target the arguments to _fb_nand_write are
> incompatible:
>
>   drivers/fastboot/fb_nand.c: In function ‘_fb_nand_write’:
>   drivers/fastboot/fb_nand.c:101:42: warning: passing argument 3 of ‘nand_write_skip_bad’ from incompatible pointer type [-Wincompatible-pointer-types]
>     return nand_write_skip_bad(mtd, offset, &length, written,
>                                           ^
>   In file included from drivers/fastboot/fb_nand.c:16:0:
>   include/nand.h:107:5: note: expected ‘size_t * {aka long unsigned int *}’ but argument is of type ‘unsigned int *’
>    int nand_write_skip_bad(struct mtd_info *mtd, loff_t offset, size_t *length,
>        ^~~~~~~~~~~~~~~~~~~
> Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com>
> ---
>
> Changes in v3:
> - new
>
> Changes in v2: None
>
>  drivers/fastboot/fb_nand.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

  reply	other threads:[~2018-05-14 19:52 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-14  9:08 [U-Boot] [PATCH v3 00/13] Add fastboot UDP support Alex Kiernan
2018-05-14  9:08 ` [U-Boot] [PATCH v3 01/13] fastboot: Move fastboot to drivers/fastboot Alex Kiernan
2018-05-14  9:08 ` [U-Boot] [PATCH v3 02/13] fastboot: Switch dependencies on FASTBOOT to USB_FUNCTION_FASTBOOT Alex Kiernan
2018-05-14  9:08 ` [U-Boot] [PATCH v3 03/13] fastboot: Refactor fastboot_okay/fail to take response Alex Kiernan
2018-05-14  9:08 ` [U-Boot] [PATCH v3 04/13] fastboot: Extract fastboot_okay/fail to fb_common.c Alex Kiernan
2018-05-14  9:09 ` [U-Boot] [PATCH v3 05/13] fastboot: Correct dependencies in FASTBOOT_FLASH Alex Kiernan
2018-05-14  9:09 ` [U-Boot] [PATCH v3 06/13] fastboot: Add missing newlines Alex Kiernan
2018-05-14  9:09 ` [U-Boot] [PATCH v3 07/13] fastboot: Remove FIXME for CONFIG_FASTBOOT_...NAME Alex Kiernan
2018-05-14 19:52   ` Simon Glass
2018-05-14  9:09 ` [U-Boot] [PATCH v3 08/13] fastboot: Fix parameter types in _fb_nand_write Alex Kiernan
2018-05-14 19:52   ` Simon Glass [this message]
2018-05-14  9:09 ` [U-Boot] [PATCH v3 09/13] fastboot: Rename fb_set_reboot_flag to fastboot_set_reboot_flag Alex Kiernan
2018-05-14 19:52   ` Simon Glass
2018-05-14  9:09 ` [U-Boot] [PATCH v3 10/13] fastboot: Extract common definitions from USB fastboot Alex Kiernan
2018-05-14 19:52   ` Simon Glass
2018-05-14 20:39     ` Alex Kiernan
2018-05-14  9:09 ` [U-Boot] [PATCH v3 11/13] ti: fastboot: Move weak overrides to board files Alex Kiernan
2018-05-14 19:53   ` Simon Glass
2018-05-14  9:09 ` [U-Boot] [PATCH v3 12/13] fs: Add fs_get_type_name to return current filesystem name Alex Kiernan
2018-05-14 19:53   ` Simon Glass
2018-05-14  9:09 ` [U-Boot] [PATCH v3 13/13] net: fastboot: Merge AOSP UDP fastboot Alex Kiernan
2018-05-14 19:53   ` Simon Glass
2018-05-14 21:11     ` Alex Kiernan
2018-05-15 16:05       ` Simon Glass
2018-05-16 15:37         ` Alex Kiernan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPnjgZ1-AmvUWPmQMcaVH3SuFA9cSdKzx0W4E==scEyHYJZBmQ@mail.gmail.com' \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.