From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A375C433EF for ; Fri, 15 Oct 2021 15:15:23 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B40AF60E0C for ; Fri, 15 Oct 2021 15:15:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B40AF60E0C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id EE23D8362D; Fri, 15 Oct 2021 17:15:19 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="nZPVfpH5"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3CB4383695; Fri, 15 Oct 2021 17:15:18 +0200 (CEST) Received: from mail-vk1-xa31.google.com (mail-vk1-xa31.google.com [IPv6:2607:f8b0:4864:20::a31]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0DCCD829FC for ; Fri, 15 Oct 2021 17:15:14 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-vk1-xa31.google.com with SMTP id m199so5327806vka.6 for ; Fri, 15 Oct 2021 08:15:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OEd/KhOxzWegZ7z51ieHNV+sbHDgWsB6B7qXizlEnpE=; b=nZPVfpH5HZt4F6ZbR1h0eXp8kSCogN6e0EVMWP8kVzcl/K9YEe31STRBs7vxznvlWY b9fz62sXS41vprooAmsS0UbdHMXV572Tx7XcdCZ4i4yW9fXXoA2AdSOfP7CXQjKA6q9b Pk7QfgyB3GQqrxqajEqgmwrrqSmEz5kPhD7c4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OEd/KhOxzWegZ7z51ieHNV+sbHDgWsB6B7qXizlEnpE=; b=20x2MimMEN2w5eiFxNSx7DdZWOipqepM9dAoVpt/T1SnLJp5PtLfIZCjKBsz65Qn81 ZRyQuZ+9+Rsmv8YX6bFMRUUHN9qhgCn2YUXPLQgaTUiAMBVsCJPU20hTZB7/O8ZOlNh6 pEqKHCmNcBoTbkRQEWepAZe2JTBt1Qf1wDuvtbwmS5Ov+KAUaMQYjd8YjckRWy6ZE4no T9Xxlq5qM8iW66fNgeKSkTiMYfCvaqlYpZ5aGC+bgVeJB2rQElcq1MylA1+yiN7u8XVY cBEdO+gFZY0+q0R67yREwx61h6FM9sgsK22DGl75Y8+lwiu+cHU0OAiHLAaLnv+QjLKQ xn6Q== X-Gm-Message-State: AOAM533r/G2IhrRGHTKDpdFXKc1VgqWTXMMrzprnNXteWwFnYIIHe4BX /2uXgithhMsSPt5pmhnssEZvxQvH46ZAncnHPuAYjg== X-Google-Smtp-Source: ABdhPJyrBY9BP1GjctoxOLwNDetENP1QoreHA3WHjnkQvYLc+rXQiLoQEExqizNCzBOt8Rgt6+VMGRP8h3eSX06mOHU= X-Received: by 2002:a1f:3193:: with SMTP id x141mr12745692vkx.9.1634310912501; Fri, 15 Oct 2021 08:15:12 -0700 (PDT) MIME-Version: 1.0 References: <20211014182257.468649-1-sjg@chromium.org> <20211014122254.v6.4.Ie78bfbfca0d01d9cba501e127f446ec48e1f7afe@changeid> <3341802.1634308345@gemini.denx.de> In-Reply-To: <3341802.1634308345@gemini.denx.de> From: Simon Glass Date: Fri, 15 Oct 2021 09:15:00 -0600 Message-ID: Subject: Re: [PATCH v6 4/7] env: Allow U-Boot scripts to be placed in a .env file To: Wolfgang Denk Cc: U-Boot Mailing List , Heinrich Schuchardt , Tom Rini , Joe Hershberger Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Wolfgang, On Fri, 15 Oct 2021 at 08:32, Wolfgang Denk wrote: > > Dear Simon Glass, > > In message <20211014122254.v6.4.Ie78bfbfca0d01d9cba501e127f446ec48e1f7afe@changeid> you wrote: > > At present U-Boot environment variables, and thus scripts, are defined > > by CONFIG_EXTRA_ENV_SETTINGS. It is painful to add large amounts of text > > to this file and dealing with quoting and newlines is harder than it > > should be. It would be better if we could just type the script into a > > text file and have it included by U-Boot. > > > > Add a feature that brings in a .env file associated with the board > > config, if present. To use it, create a file in a board//env > > directory called .env (or common.env if you want the same > > environment for all boards). > > Argh... did you bother to read my comments? Apparently not. > > Thus: > > NAKed by: Wolfgang Denk > > > I really think your fixed filename proposal does not work well in > reality. The file name should be Kconfig configurable. See [1] > for details. > > [1] https://lists.denx.de/pipermail/u-boot/2021-October/462668.html Yes I saw that but I forgot to look at it. I think it makes sense - we do that with devicetree, for example. Is that the only thing holding you back? I haven't seen any positive comments to this series yet... Regards, Simon