From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E8223C433EF for ; Wed, 12 Jan 2022 20:10:03 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BFBF18370B; Wed, 12 Jan 2022 21:05:43 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="mRljzMah"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id EE63C8364D; Wed, 12 Jan 2022 21:05:24 +0100 (CET) Received: from mail-oo1-xc2b.google.com (mail-oo1-xc2b.google.com [IPv6:2607:f8b0:4864:20::c2b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id EF37783628 for ; Wed, 12 Jan 2022 21:05:20 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-oo1-xc2b.google.com with SMTP id x21-20020a4a2a55000000b002ddf492c201so723842oox.6 for ; Wed, 12 Jan 2022 12:05:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fA47I29I8+qYUjyvRa7zyjI6TzXc9w9Z2I5rfiYNbAU=; b=mRljzMah9QCtvt/8ekJgfh+8KAbNuJH2sWE8Hbnx26mycsGgQk/h5CNXB6T47lS09y s/mO3JZozuaebwSEev2izAefLhvLXjxq1nMEyQtU8bKMX8HLQzUI/oPylXSNFfzLVq/S G4VtbPq9TAeZ507ZP68XdBrq1MOe4/NWqTOzc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fA47I29I8+qYUjyvRa7zyjI6TzXc9w9Z2I5rfiYNbAU=; b=C/6VFRbNiDdy7dqiyFwTyAZGZ8DL+HXSyJ48KR6LtraoQg2oc8j7g3YPBcdxNIZwUY iG44a4RqTzbHI+mcv3LuYpEx4JVKjwgk99bpN2iWlXv3bb35VLskopOXeb4py21D+qRD JLRihjkaPLY4JxZlyov0czLjjDgGTh//jFHxIZseBuKcrOhsuSSznlDhTmBI05JZgpQh vJwhGmocXfWCQeqRgMqNYjdTqxZmfBgXPtmfPQNmSRUH8TL45WfS9fb9MciG4Rk8lNDw 2MgbY1BhQ+BbROyxvtaAApiQ/wBVoP80gfrhR8o/+nGdstQNFkm6VXCx96XPo/S9lyBr 7jWA== X-Gm-Message-State: AOAM533uu78hhL8Fp3j+dpe8lBzJ1J8z634iTlR4wbcc0R7EVYcA1BDw OPgXjz5vpOUNvgeD1PSDnDyWJ3Pg5gWoh84XdxG6LPHZeVY= X-Google-Smtp-Source: ABdhPJyIyKOAn/XxRGzT+stT033BngWpYYB1O2hdJtPQE3nOodQXe1Y1ozZ/uY1uRZE5bFLqJCdSTALTckUck0GqckY= X-Received: by 2002:a4a:4c45:: with SMTP id a66mr790020oob.97.1642017919470; Wed, 12 Jan 2022 12:05:19 -0800 (PST) MIME-Version: 1.0 References: <20211230164825.6489-1-jbx6244@gmail.com> <20211230164825.6489-5-jbx6244@gmail.com> In-Reply-To: <20211230164825.6489-5-jbx6244@gmail.com> From: Simon Glass Date: Wed, 12 Jan 2022 13:03:24 -0700 Message-ID: Subject: Re: [PATCH v3 5/6] rockchip: spl: replace ifdef by IS_ENABLED for timer_init() call condition To: Johan Jonker Cc: Kever Yang , Philipp Tomsich , U-Boot Mailing List Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Thu, 30 Dec 2021 at 09:48, Johan Jonker wrote: > > Not all Rockchip SoC models use the ARM arch timer. > Call the function timer_init() only when > CONFIG_SYS_ARCH_TIMER is available. > Replace the ifdef call condition by IS_ENABLED > to increase build coverage and make the code easier to read. > > Signed-off-by: Johan Jonker > --- > arch/arm/mach-rockchip/spl.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Simon Glass